From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Fix PR python/18984
Date: Thu, 02 Jun 2016 18:22:00 -0000 [thread overview]
Message-ID: <20160602182215.GB3769@adacore.com> (raw)
In-Reply-To: <87shwvwjoq.fsf@tromey.com>
Hey Tom,
> Tom> This fixes PR python/18984.
> Tom> The bug is that gdbpy_solib_name uses GDB_PY_LL_ARG, whereas it should
> Tom> use GDB_PY_LLU_ARG to avoid overflow.
>
> Tom> Built and tested on x86-64 Fedora 23.
>
> Tom> 2016-05-18 Tom Tromey <tom@tromey.com>
>
> Tom> PR python/18984:
> Tom> * python/python.c (gdbpy_solib_name): Use GDB_PY_LLU_ARG.
>
> Ping.
>
> This one bit me again today, and the fix is particularly simple.
Sorry about the delay. The code patch looks good to me. For the testcase
patch, you said you'd be adjusting it for Python 3 as well? Just for
the avoidance of doubt, you're pre-approved on that as well. If there
are comments on it, we can address those later, as it wouldn't break
GDB anyways.
Thanks!
--
Joel
next prev parent reply other threads:[~2016-06-02 18:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 23:37 Tom Tromey
2016-05-20 19:48 ` Tom Tromey
2016-06-02 18:05 ` Tom Tromey
2016-06-02 18:22 ` Joel Brobecker [this message]
2016-06-02 19:24 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160602182215.GB3769@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox