From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93105 invoked by alias); 4 Apr 2016 14:41:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93008 invoked by uid 89); 4 Apr 2016 14:41:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1273 X-HELO: e06smtp09.uk.ibm.com Received: from e06smtp09.uk.ibm.com (HELO e06smtp09.uk.ibm.com) (195.75.94.105) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Mon, 04 Apr 2016 14:41:08 +0000 Received: from localhost by e06smtp09.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 4 Apr 2016 15:41:05 +0100 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp09.uk.ibm.com (192.168.101.139) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 4 Apr 2016 15:41:04 +0100 X-IBM-Helo: d06dlp01.portsmouth.uk.ibm.com X-IBM-MailFrom: uweigand@de.ibm.com X-IBM-RcptTo: gdb-patches@sourceware.org Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 4B7F317D8059 for ; Mon, 4 Apr 2016 15:41:44 +0100 (BST) Received: from d06av10.portsmouth.uk.ibm.com (d06av10.portsmouth.uk.ibm.com [9.149.37.251]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u34Ef3831835282 for ; Mon, 4 Apr 2016 14:41:03 GMT Received: from d06av10.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av10.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u34Df51j011907 for ; Mon, 4 Apr 2016 07:41:05 -0600 Received: from oc7340732750.ibm.com (dyn-9-152-213-105.boeblingen.de.ibm.com [9.152.213.105]) by d06av10.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u34Df55X011896; Mon, 4 Apr 2016 07:41:05 -0600 Received: by oc7340732750.ibm.com (Postfix, from userid 500) id E702CCAA4; Mon, 4 Apr 2016 16:41:02 +0200 (CEST) Subject: Re: [PATCH] IPA: Fix build problem on !HAVE_GETAUXVAL To: koriakin@0x04.net (=?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?=) Date: Mon, 04 Apr 2016 14:41:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <570144A1.7050700@0x04.net> from "=?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?=" at Apr 03, 2016 06:28:17 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-Id: <20160404144102.E702CCAA4@oc7340732750.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16040414-0037-0000-0000-000009E73076 X-SW-Source: 2016-04/txt/msg00041.txt.bz2 > On 03/04/16 18:20, Ulrich Weigand wrote: > >> These files need AT_PHDR, which is defined in elf.h. If HAVE_GETAUXVAL > >> is set, it's implicitely included by sys/auxv.h. Include it manually > >> for the opposite case. > >> > >> gdb/gdbserver/ChangeLog: > >> > >> * linux-aarch64-ipa.c: Add include. > >> * linux-ppc-ipa.c: Add include. > >> * linux-s390-ipa.c: Add include. > >> --- > >> Here's a fix. Does that sound right? > > > > This is OK. > > > > Thanks, > > Ulrich > > > > Thanks, pushed. Hmm, it turns out build still fails for me, this time in the link step: linux-ppc-ipa.o: In function `alloc_jump_pad_buffer': gdb/gdbserver/linux-ppc-ipa.c:121: undefined reference to `getauxval' Looking at tracepoint.c, I notice that the definition of getauxval #if !defined HAVE_GETAUXVAL && defined IN_PROCESS_AGENT /* Retrieve the value of TYPE from the auxiliary vector. If TYPE is not found, 0 is returned. This function is provided if glibc is too old. */ unsigned long getauxval (unsigned long type) is itself within a #ifndef IN_PROCESS_AGENT block, and so never has any effect ... Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com