From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120982 invoked by alias); 30 Mar 2016 11:30:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 120959 invoked by uid 89); 30 Mar 2016 11:30:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=agent X-HELO: e06smtp11.uk.ibm.com Received: from e06smtp11.uk.ibm.com (HELO e06smtp11.uk.ibm.com) (195.75.94.107) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Wed, 30 Mar 2016 11:30:23 +0000 Received: from localhost by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 30 Mar 2016 12:30:11 +0100 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 30 Mar 2016 12:30:09 +0100 X-IBM-Helo: d06dlp01.portsmouth.uk.ibm.com X-IBM-MailFrom: uweigand@de.ibm.com X-IBM-RcptTo: gdb-patches@sourceware.org Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 4A60817D8056 for ; Wed, 30 Mar 2016 12:30:46 +0100 (BST) Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u2UBU88D66781218 for ; Wed, 30 Mar 2016 11:30:08 GMT Received: from d06av04.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u2UBU7XQ001753 for ; Wed, 30 Mar 2016 05:30:07 -0600 Received: from oc7340732750.ibm.com (dyn-9-152-213-105.boeblingen.de.ibm.com [9.152.213.105]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u2UBU634001662; Wed, 30 Mar 2016 05:30:06 -0600 Received: by oc7340732750.ibm.com (Postfix, from userid 500) id 8216F7704; Wed, 30 Mar 2016 13:30:06 +0200 (CEST) Subject: Re: [PATCH 1/3] gdbserver/IPA: Export some functions via global function pointers. To: palves@redhat.com (Pedro Alves) Date: Wed, 30 Mar 2016 11:30:00 -0000 From: "Ulrich Weigand" Cc: koriakin@0x04.net (=?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?=), gdb-patches@sourceware.org In-Reply-To: <56FAF8D8.1070207@redhat.com> from "Pedro Alves" at Mar 29, 2016 10:51:20 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-Id: <20160330113006.8216F7704@oc7340732750.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16033011-0041-0000-0000-00000E741FE4 X-SW-Source: 2016-03/txt/msg00555.txt.bz2 Pedro Alves wrote: > On 03/29/2016 07:08 PM, Ulrich Weigand wrote: > > > However, there does seem to be one issue: your patch changes the > > interface between gdbserver and the in-process agent in an incompatible > > way. Binaries with an old IPA built in will no longer work with a > > new gdbserver, since it will will expect exported symbols like > > gdb_collect_ptr, which the old binary doesn't export. > > > > I think it would be preferable to implement a backward-compatible > > way where gdbserver checks for the new symbol, and if it isn't > > present, falls back to the old symbol. > > So far, given the tight coupling between gdbserver and the IPA's > implementation, we've required that gdbserver and the IPA must > be of the same version. We're added new functions to the > interface before without trying to maintain backwards compatibility. Ah, OK, I didn't realize that. That's fine with me as well. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com