From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116428 invoked by alias); 29 Mar 2016 18:31:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 116413 invoked by uid 89); 29 Mar 2016 18:31:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1444 X-HELO: e06smtp12.uk.ibm.com Received: from e06smtp12.uk.ibm.com (HELO e06smtp12.uk.ibm.com) (195.75.94.108) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Tue, 29 Mar 2016 18:31:00 +0000 Received: from localhost by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 29 Mar 2016 19:30:57 +0100 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 29 Mar 2016 19:30:54 +0100 X-IBM-Helo: d06dlp01.portsmouth.uk.ibm.com X-IBM-MailFrom: uweigand@de.ibm.com X-IBM-RcptTo: gdb-patches@sourceware.org Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 39AEA17D8042 for ; Tue, 29 Mar 2016 19:31:31 +0100 (BST) Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u2TIUroI6160740 for ; Tue, 29 Mar 2016 18:30:53 GMT Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u2TIUqoM007549 for ; Tue, 29 Mar 2016 12:30:53 -0600 Received: from oc7340732750.ibm.com (dyn-9-152-213-47.boeblingen.de.ibm.com [9.152.213.47]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u2TIUqLW007546; Tue, 29 Mar 2016 12:30:52 -0600 Received: by oc7340732750.ibm.com (Postfix, from userid 500) id BAAEDC9C7; Tue, 29 Mar 2016 20:30:52 +0200 (CEST) Subject: Re: [PATCH v4] gdbserver/s390: Switch on tracepoint support. To: koriakin@0x04.net (=?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?=) Date: Tue, 29 Mar 2016 18:31:00 -0000 From: "Ulrich Weigand" Cc: arnez@linux.vnet.ibm.com (Andreas Arnez), gdb-patches@sourceware.org, keiths@redhat.com (Keith Seitz) In-Reply-To: <56F33FC0.1020006@0x04.net> from "=?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?=" at Mar 24, 2016 02:15:44 AM MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-Id: <20160329183052.BAAEDC9C7@oc7340732750.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16032918-0009-0000-0000-00000B480E0B X-SW-Source: 2016-03/txt/msg00532.txt.bz2 Marcin Kościelnicki wrote: > On 23/03/16 16:25, Andreas Arnez wrote: > > On Tue, Mar 15 2016, Marcin Kościelnicki wrote: > > > >> Also adds s390 support to gdb.trace testsuite. > >> > >> gdb/gdbserver/ChangeLog: > >> > >> * linux-s390-low.c (s390_supports_tracepoints): New function. > >> (struct linux_target_ops): Fill supports_tracepoints hook. > >> > >> gdb/testsuite/ChangeLog: > >> > >> * gdb.trace/ftrace.exp: Set arg0exp for s390. > >> * gdb.trace/mi-trace-frame-collected.exp: Expect 4 registers on s390. > >> * gdb.trace/mi-trace-unavailable.exp: Set pcnum for s390, add gpr0num > >> variable for GPR 0 instead of assuming it is register 0. > >> * gdb.trace/trace-common.h: Add s390 fast tracepoint placeholder. > >> * lib/trace-support.exp: Add s390 registers. > >> --- > >> This fixes a minor conflict with the powerpc regular tracepoint support > >> pushed in the meantime (mi-trace-unavailable.exp now needs gpr0num in > >> powerpc branch). > > > > Please also document this new feature in the NEWS file. > > OK, I'll submit another patch adding the NEWS entry (it should go after > the fast tracepoints). > > Otherwise the patch looks good to me. But I think a global- or > > testsuite-maintainer should approve the changes to the testsuite. Those changes are OK. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com