From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49921 invoked by alias); 29 Mar 2016 18:08:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 49868 invoked by uid 89); 29 Mar 2016 18:08:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=alright, Alright, H*UA:2.5, H*x:2.5 X-HELO: e06smtp08.uk.ibm.com Received: from e06smtp08.uk.ibm.com (HELO e06smtp08.uk.ibm.com) (195.75.94.104) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Tue, 29 Mar 2016 18:08:42 +0000 Received: from localhost by e06smtp08.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 29 Mar 2016 19:08:38 +0100 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp08.uk.ibm.com (192.168.101.138) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 29 Mar 2016 19:08:36 +0100 X-IBM-Helo: d06dlp01.portsmouth.uk.ibm.com X-IBM-MailFrom: uweigand@de.ibm.com X-IBM-RcptTo: gdb-patches@sourceware.org Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 6C68A17D805A for ; Tue, 29 Mar 2016 19:09:13 +0100 (BST) Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u2TI8ZdS64815344 for ; Tue, 29 Mar 2016 18:08:35 GMT Received: from d06av06.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u2TI8Zh3024957 for ; Tue, 29 Mar 2016 14:08:35 -0400 Received: from oc7340732750.ibm.com (dyn-9-152-213-47.boeblingen.de.ibm.com [9.152.213.47]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u2TI8ZOL024940; Tue, 29 Mar 2016 14:08:35 -0400 Received: by oc7340732750.ibm.com (Postfix, from userid 500) id 1AA33C9C7; Tue, 29 Mar 2016 20:08:35 +0200 (CEST) Subject: Re: [PATCH 1/3] gdbserver/IPA: Export some functions via global function pointers. To: koriakin@0x04.net (=?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?=) Date: Tue, 29 Mar 2016 18:08:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <56F10E02.2090403@0x04.net> from "=?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?=" at Mar 22, 2016 10:18:58 AM MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-Id: <20160329180835.1AA33C9C7@oc7340732750.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16032918-0033-0000-0000-00000AE60898 X-SW-Source: 2016-03/txt/msg00526.txt.bz2 Marcin Kościelnicki wrote: > On 14/03/16 18:49, Ulrich Weigand wrote: > > The more I think about it, the more I tend to agree that your > > proposal is actually the best solution. I'd still like to give > > it a couple of days to give others a chance to comment as well ... > > Alright, so what should we do about this issue? Since nobody came up with a better idea, and since your patch doesn't actually preclude anybody from implementing any better idea they might come up later (since it doesn't actually change anything in the gdbserver protocol), I'd say we just go with your patch for now. However, there does seem to be one issue: your patch changes the interface between gdbserver and the in-process agent in an incompatible way. Binaries with an old IPA built in will no longer work with a new gdbserver, since it will will expect exported symbols like gdb_collect_ptr, which the old binary doesn't export. I think it would be preferable to implement a backward-compatible way where gdbserver checks for the new symbol, and if it isn't present, falls back to the old symbol. Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com