From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23425 invoked by alias); 17 Mar 2016 06:30:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23415 invoked by uid 89); 17 Mar 2016 06:30:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: e06smtp08.uk.ibm.com Received: from e06smtp08.uk.ibm.com (HELO e06smtp08.uk.ibm.com) (195.75.94.104) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Thu, 17 Mar 2016 06:30:51 +0000 Received: from localhost by e06smtp08.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 17 Mar 2016 06:30:48 -0000 Received: from d06dlp03.portsmouth.uk.ibm.com (9.149.20.15) by e06smtp08.uk.ibm.com (192.168.101.138) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 17 Mar 2016 06:30:46 -0000 X-IBM-Helo: d06dlp03.portsmouth.uk.ibm.com X-IBM-MailFrom: uweigand@de.ibm.com X-IBM-RcptTo: gdb-patches@sourceware.org Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 7C2A01B0807D for ; Thu, 17 Mar 2016 06:31:15 +0000 (GMT) Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u2H6UkSe8388972 for ; Thu, 17 Mar 2016 06:30:46 GMT Received: from d06av04.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u2H6UjXq030307 for ; Thu, 17 Mar 2016 00:30:45 -0600 Received: from oc7340732750.ibm.com (icon-9-164-170-202.megacenter.de.ibm.com [9.164.170.202]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u2H6UifH030270; Thu, 17 Mar 2016 00:30:44 -0600 Received: by oc7340732750.ibm.com (Postfix, from userid 500) id CC6151537; Thu, 17 Mar 2016 07:30:43 +0100 (CET) Subject: Re: [PATCH 3/4 v2] gdbserver: Add powerpc fast tracepoint support. To: koriakin@0x04.net (=?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?=) Date: Thu, 17 Mar 2016 06:30:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <56E99DFA.7080206@0x04.net> from "=?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?=" at Mar 16, 2016 06:55:06 PM MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-Id: <20160317063043.CC6151537@oc7340732750.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16031706-0033-0000-0000-00000677005A X-SW-Source: 2016-03/txt/msg00283.txt.bz2 Marcin Kościelnicki wrote: > On 16/03/16 17:58, Ulrich Weigand wrote: > > Was there a particular reason why you changed to using direct ptrace > > calls instead of collecting the value from the regcache as in the > > original patch? > > Not really, I just happened to had this bit written before I learned of > Wei-cheng's patches. What are your preferences here? I think using collect_register_by_name is probably better. Then you also shouldn't need to do this: +#ifdef __powerpc64__ + if (!is_64) + *addr &= 0xffffffffull; +#endif because that should be handled automatically by the regcache logic. Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com