From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107827 invoked by alias); 9 Mar 2016 17:35:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 107816 invoked by uid 89); 9 Mar 2016 17:35:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=our, HContent-Transfer-Encoding:8bit X-HELO: e06smtp11.uk.ibm.com Received: from e06smtp11.uk.ibm.com (HELO e06smtp11.uk.ibm.com) (195.75.94.107) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Wed, 09 Mar 2016 17:35:12 +0000 Received: from localhost by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 9 Mar 2016 17:35:09 -0000 Received: from d06dlp02.portsmouth.uk.ibm.com (9.149.20.14) by e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 9 Mar 2016 17:35:07 -0000 X-IBM-Helo: d06dlp02.portsmouth.uk.ibm.com X-IBM-MailFrom: uweigand@de.ibm.com X-IBM-RcptTo: gdb-patches@sourceware.org Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id BF7B6219005E for ; Wed, 9 Mar 2016 17:34:49 +0000 (GMT) Received: from d06av10.portsmouth.uk.ibm.com (d06av10.portsmouth.uk.ibm.com [9.149.37.251]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u29HZ6Ha8651232 for ; Wed, 9 Mar 2016 17:35:06 GMT Received: from d06av10.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av10.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u29GZ8i6004952 for ; Wed, 9 Mar 2016 09:35:08 -0700 Received: from oc7340732750.ibm.com (dyn-9-152-213-148.boeblingen.de.ibm.com [9.152.213.148]) by d06av10.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u29GZ8Mt004948; Wed, 9 Mar 2016 09:35:08 -0700 Received: by oc7340732750.ibm.com (Postfix, from userid 500) id 646E6C88E; Wed, 9 Mar 2016 18:35:06 +0100 (CET) Subject: Re: [PATCH 4/8] gdb.trace: Use manually-defined start labels in unavailable-dwarf-piece.exp To: koriakin@0x04.net (=?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?=) Date: Wed, 09 Mar 2016 17:35:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <56E05CF2.8020305@0x04.net> from "=?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?=" at Mar 09, 2016 06:27:14 PM MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-Id: <20160309173506.646E6C88E@oc7340732750.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16030917-0041-0000-0000-000007D6139C X-SW-Source: 2016-03/txt/msg00143.txt.bz2 Marcin Kościelnicki wrote: > On 09/03/16 18:24, Ulrich Weigand wrote: > > Marcin Kościelnicki wrote: > > > >> On powerpc64, foo/bar point to a function descriptor, not to function code. > >> Since there are no global labels pointing at the actual function code, > >> let's make our own. > > > >> with_test_prefix "tracing foo" { > >> - gdb_test "trace foo" ".*" > >> + gdb_test "trace *foo_start_lbl" ".*" > > > > Well, I'd have thought that "trace foo" should simply work as-is, > > otherwise, this isn't particularly user-friedly ... > > > > Is there a call to gdbarch_convert_from_func_ptr_addr missing > > somewhere in the trace code, maybe? > > Don't worry, trace foo does work, but not for this particular test, > because of the way the fake DWARF is emitted: before, the DWARF covered > area from foo to foo_end_lbl, and thus a tracepoint set on foo worked > just fine. However, now the DWARF covers foo_start_lbl to foo_end_lbl - > and function entry point (which is where the tracepoint is) is not covered. Ah, I see. The patch is OK, then. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com