From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51100 invoked by alias); 26 Feb 2016 05:08:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 51084 invoked by uid 89); 26 Feb 2016 05:08:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=encouraging, Hx-languages-length:870, H*r:sk:c-73-15, H*RU:sk:c-73-15 X-HELO: mail-lf0-f65.google.com Received: from mail-lf0-f65.google.com (HELO mail-lf0-f65.google.com) (209.85.215.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 26 Feb 2016 05:08:03 +0000 Received: by mail-lf0-f65.google.com with SMTP id j99so3192848lfi.2 for ; Thu, 25 Feb 2016 21:08:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=b2ZM7nqDDlFoQnwAGc9FhNlTfUAnC76YHi94wlmt1yg=; b=dl7GVC9tElGrccPIjje+zNOwuL1PMYyShZugK1KdDnYrPbdzUk0t6V9pYbTarER8AI cDkZzo9Rhjw+/y/nJP2rXrjzSY/+4AemhBgdK3KAcjUFaHScTnOZG7r3+W3EuXN1Oeg7 E3uZrhFw4WSvK7MM0OzF8+pAqH4Di/oY04JS6kzBOwtRGJQnSAOWgnMT/X4lHXerjzwJ zxkiU6oVR0yt3cg4qVC/8dTzfx84xRpkgqztoWjVHRgafCzwLOT1v9wFamrYac4x55cY 9AmHy0ElIDmR3axpGx3Cbgpn8QPsuCi1CDmvwWtQ70nw1vDIKaCYCpd8Y2bZEEo+ZOnf A4JQ== X-Gm-Message-State: AG10YOSy9rkEseMr2D5uafrCHPYy2oXL5CaxC1V4t7dFYTkHs6nGA20E/Xg5fXe96vlD5A== X-Received: by 10.25.10.200 with SMTP id 191mr19177009lfk.116.1456463279701; Thu, 25 Feb 2016 21:07:59 -0800 (PST) Received: from gmail.com (c-73-15-67-137.hsd1.ca.comcast.net. [73.15.67.137]) by smtp.gmail.com with ESMTPSA id i186sm1568353lfb.30.2016.02.25.21.07.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Feb 2016 21:07:58 -0800 (PST) Date: Fri, 26 Feb 2016 05:08:00 -0000 From: Artemiy Volkov To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 08/11] [PR gdb/14441] gdb: convert lvalue reference type check to general reference type check Message-ID: <20160226050650.GA24509@gmail.com> References: <1450661481-31178-1-git-send-email-artemiyv@acm.org> <1453229609-20159-1-git-send-email-artemiyv@acm.org> <1453229609-20159-9-git-send-email-artemiyv@acm.org> <56C7666D.9000700@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56C7666D.9000700@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00834.txt.bz2 On Fri, Feb 19, 2016 at 11:01:01AM -0800, Keith Seitz wrote: [snip] > > 2016-01-19 Artemiy Volkov > > > > * gdb/aarch64-tdep.c (aarch64_type_align): Change TYPE_CODE_REF > > check to TYPE_REFERENCE check. > > (aarch64_extract_return_value): Likewise. > > (aarch64_store_return_value): Likewise. > > * gdb/amd64-tdep.c (amd64_classify): Likewise. > [big snip] > > We are now encouraging/permitting developers to use the phrase "Update > all callers." or "All callers updated." with large, mechanical changes > like this. > This phrase doesn't fit here, does it? There's no function signature changes, thus no callers really get updated. Maybe I should leave the "likewise"s as they were or rephrase it in some other way? Thanks, Artemiy