From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71332 invoked by alias); 25 Feb 2016 01:45:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71320 invoked by uid 89); 25 Feb 2016 01:45:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:gmail.com, H*RU:gmail.com, Hx-spam-relays-external:gmail.com X-HELO: mail-lf0-f68.google.com Received: from mail-lf0-f68.google.com (HELO mail-lf0-f68.google.com) (209.85.215.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 25 Feb 2016 01:45:47 +0000 Received: by mail-lf0-f68.google.com with SMTP id h198so1447003lfh.3 for ; Wed, 24 Feb 2016 17:45:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=Qgh1bGlaJPMzPJSweub6JNWIbHC70enXjSUgLnbKnn4=; b=hHLTFJveZlOG0PSYVPoBRnSwZQ6eIlw8ESY8aMFMrPLMI3iw0vUVRDweByDn4RuJi1 W3ifyo/j9tp1wQ5zJ/Jh62ZtH45Rxnmae0uEx7h42yf4Qpknxsj4wDkNGOBOysDSgwp+ Q6ac/oi7FaAo6SaRIxjcIR2i5t1G55H2l8MfQ5nLM6z0nOI3aqZcKniVo6C71IRNJIpo IAHjqwPpDDbmbIecIQoet5mPpvG0PSwfzE5/OJPOkgQe1DNgNnhwfvbfuTZc4zM9Jl8w +h+/J7DoyJbg0uFkTJICxEhhlDBwhaulpKKpL8vgD2qZglhISEEu50xsCnCtXjLMGPKf sglA== X-Gm-Message-State: AG10YOSIU8ZO/dzRl46zxtTFBfZkL0Ooyqwxrm/szJLXaobfc1KzOiG3ffWHsxXY37dWjA== X-Received: by 10.25.80.6 with SMTP id e6mr16377517lfb.91.1456364743137; Wed, 24 Feb 2016 17:45:43 -0800 (PST) Received: from gmail.com (108-60-110-19.static.wiline.com. [108.60.110.19]) by smtp.gmail.com with ESMTPSA id zr6sm747341lbb.19.2016.02.24.17.45.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Feb 2016 17:45:42 -0800 (PST) Date: Thu, 25 Feb 2016 01:45:00 -0000 From: Artemiy Volkov To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 01/11] [PR gdb/14441] gdb: gdbtypes: add definitions for rvalue reference type Message-ID: <20160225014505.GA13684@gmail.com> References: <1450661481-31178-1-git-send-email-artemiyv@acm.org> <1453229609-20159-1-git-send-email-artemiyv@acm.org> <1453229609-20159-2-git-send-email-artemiyv@acm.org> <56C763C2.8090207@redhat.com> <20160223070313.GA1564@gmail.com> <56CE574A.2000406@redhat.com> <20160225013125.GA13171@gmail.com> <56CE5BB5.3090900@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56CE5BB5.3090900@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00771.txt.bz2 On Wed, Feb 24, 2016 at 05:41:09PM -0800, Keith Seitz wrote: > [bah -- forgot to "reply all"] > > On 02/24/2016 05:31 PM, Artemiy Volkov wrote: > > On Wed, Feb 24, 2016 at 05:22:18PM -0800, Keith Seitz wrote: > >> On 02/22/2016 11:03 PM, Artemiy Volkov wrote: > >>> On Fri, Feb 19, 2016 at 10:49:38AM -0800, Keith Seitz wrote: > >>> > >>> Do you suggest keeping only the lvalue version of the reference type and > >>> then adjust its type code from TYPE_CODE_REF to TYPE_CODE_RVALUE_REF on > >>> lookup_rvalue_reference_type()? It seems somewhat hacky to me. E.g. how > >>> would we be able to create a struct type for a complex type involving a > >>> T&&, such as a typedef of it? > >> > >> Bah. No, I am wrong. Please disregard this comment. > >> > >> Sorry about the confusion. > > > > No problem at all. Correct me if I am wrong, but I think this > > invalidates your remarks in 2/11 that refer to this change. Do those 2 > > hunks in 2/11 look OK now? > > Yes, ignore my comments in make_reference_type. The only thing of note > in there, then, is that we prefer the usage of explicit NULL checks: > > if (*reftype != NULL) > ... > > instead of > > if (!*reftype) > ... Gotcha. I'll make sure to fix that. > > Keith Thanks, Artemiy