From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60774 invoked by alias); 24 Feb 2016 11:56:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 60756 invoked by uid 89); 24 Feb 2016 11:56:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 24 Feb 2016 11:56:43 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id B637F85545; Wed, 24 Feb 2016 11:56:41 +0000 (UTC) Received: from blade.nx (ovpn-116-96.ams2.redhat.com [10.36.116.96]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1OBuf4B017166; Wed, 24 Feb 2016 06:56:41 -0500 Received: by blade.nx (Postfix, from userid 1000) id 71510264435; Wed, 24 Feb 2016 11:56:40 +0000 (GMT) Date: Wed, 24 Feb 2016 11:56:00 -0000 From: Gary Benson To: Pedro Alves Cc: gdb-patches@sourceware.org, Luis Machado Subject: Re: [PATCH v2] Fix logic in exec_file_locate_attach Message-ID: <20160224115640.GB16390@blade.nx> References: <20160219102447.GA29870@blade.nx> <1455880879-310-1-git-send-email-gbenson@redhat.com> <56CC48BB.2010408@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56CC48BB.2010408@redhat.com> X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00719.txt.bz2 Pedro Alves wrote: > On 02/19/2016 11:21 AM, Gary Benson wrote: > > This commit fixes an error in exec_file_locate_attach where > > the main executable could be loaded from outside the sysroot > > if a nonempty, non-"target:" sysroot was set but the discovered > > executable filename did not exist in that sysroot and did exist > > on the main filesystem. > > > > gdb/ChangeLog: > > > > * exec.c (exec_file_locate_attach): Do not attempt to > > locate main executable locally if not found in sysroot. > > > > gdb/testsuite/ChangeLog: > > > > * gdb.base/attach-pie-noexec.exp: Do not expect an error > > message on attach. > > OK. Pushed. Thanks, Gary -- http://gbenson.net/