From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129975 invoked by alias); 23 Feb 2016 12:15:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 129814 invoked by uid 89); 23 Feb 2016 12:15:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1362, accessibility, xxx X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 23 Feb 2016 12:15:06 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id B23F014C811; Tue, 23 Feb 2016 12:15:04 +0000 (UTC) Received: from blade.nx (ovpn-116-96.ams2.redhat.com [10.36.116.96]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1NCF3Ik010249; Tue, 23 Feb 2016 07:15:04 -0500 Received: by blade.nx (Postfix, from userid 1000) id 7E949264437; Tue, 23 Feb 2016 12:15:02 +0000 (GMT) Date: Tue, 23 Feb 2016 12:15:00 -0000 From: Gary Benson To: Pedro Alves Cc: Luis Machado , gdb-patches@sourceware.org Subject: Re: [PATCH v2] Fix logic in exec_file_locate_attach Message-ID: <20160223121502.GA23530@blade.nx> References: <56CAF2E3.7050607@codesourcery.com> <20160222135109.GA2256@blade.nx> <56CB8506.3010602@codesourcery.com> <56CB9095.9090908@codesourcery.com> <56CB9304.9020408@redhat.com> <56CBA220.3000709@codesourcery.com> <56CBA443.6010106@redhat.com> <56CBA4BA.7050905@codesourcery.com> <20160223112721.GA22369@blade.nx> <56CC45F3.1090104@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56CC45F3.1090104@redhat.com> X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00685.txt.bz2 Pedro Alves wrote: > On 02/23/2016 11:27 AM, Gary Benson wrote: > > I hadn't considered user interrupts. > > But there's nothing about user interrupts in either of: > > https://sourceware.org/ml/gdb-patches/2016-02/msg00511.html > > or: > > https://sourceware.org/ml/gdb-patches/2016-02/msg00671.html > > That is about gdb managing to figure out the file name of the > running program, but then trying to open the file, and that failing > and throwing. Sure. But up until now I've been thinking my way through the cases in the exec_file_locate_attach in terms of file accessibility checks, and the possibility of user interrupts makes that irrelevent. I'm not averse to TRY..CATCH, in fact I think the suggestion of two separate TRY..CATCH blocks around exec_file_attach the symbol file one is the correct solution. But, there is a separate issue, which is that if you run gdbserver on some executable, and GDB has a sysroot set, and that executable does not exist in GDB's sysroot but does exist on GDB's root filesystem, then GDB will open the file from its root filesystem: gdb -ex "set sysroot /xxx" -ex "target remote | gdbserver - /bin/ls" ... Reading symbols from /bin/ls...(no debugging symbols found)...done. My v2 patch stops that. So... can I commit it? Cheers, Gary -- http://gbenson.net/