From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73030 invoked by alias); 23 Feb 2016 11:27:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 73011 invoked by uid 89); 23 Feb 2016 11:27:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=interrupts, detach X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 23 Feb 2016 11:27:25 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 2402BC0006E4; Tue, 23 Feb 2016 11:27:24 +0000 (UTC) Received: from blade.nx (ovpn-116-96.ams2.redhat.com [10.36.116.96]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1NBRMVj030929; Tue, 23 Feb 2016 06:27:23 -0500 Received: by blade.nx (Postfix, from userid 1000) id B53CA264431; Tue, 23 Feb 2016 11:27:21 +0000 (GMT) Date: Tue, 23 Feb 2016 11:27:00 -0000 From: Gary Benson To: Luis Machado Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH v2] Fix logic in exec_file_locate_attach Message-ID: <20160223112721.GA22369@blade.nx> References: <56C736ED.9040505@codesourcery.com> <20160222104034.GA31531@blade.nx> <56CAF2E3.7050607@codesourcery.com> <20160222135109.GA2256@blade.nx> <56CB8506.3010602@codesourcery.com> <56CB9095.9090908@codesourcery.com> <56CB9304.9020408@redhat.com> <56CBA220.3000709@codesourcery.com> <56CBA443.6010106@redhat.com> <56CBA4BA.7050905@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56CBA4BA.7050905@codesourcery.com> X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00682.txt.bz2 Luis Machado wrote: > On 02/22/2016 09:13 PM, Pedro Alves wrote: > > On 02/23/2016 12:04 AM, Luis Machado wrote: > > >On 02/22/2016 08:00 PM, Pedro Alves wrote: > > > > On 02/22/2016 10:49 PM, Luis Machado wrote: > > > > > On 02/22/2016 07:00 PM, Luis Machado wrote: > > > > > > My idea was to guard both exec_file_attach and > > > > > > symbol_file_add_main. We can't have anything in that > > > > > > function throwing an error that won't be caught, otherwise > > > > > > the above connection attempt will fail. > > > > > > > > > > For the record, you patch does fix the case of native GDB > > > > > trying to attach to a process without pre-loading a symbol > > > > > file. We get a multi-frame backtrace as expected. > > > > > > > > > > It is the gdb/gdbserver case that still seems to be broken. > > > > > > > > Native is also broken as well for unexpectedly aborting the > > > > attach sequence midway. While "bt" doesn't show it, "detach" > > > > does trip on it: > > > > > > Sounds like we're looking into a try/catch block around such > > > functions then? > > > > Yes, I think so. Probably best to make it two separate > > try/catches, in case the file can't be loaded as executable but > > succeeds as symbol file, for some reason. > > Ok. I have the code in place, but i'm still crafting the testcase > for both native / remote cases. Should have something later this > week. I hadn't considered user interrupts. Pedro, are you ok if I commit my v2 patch (https://sourceware.org/ml/gdb-patches/2016-02/msg00587.html) as a fix for the sysroot-escaping behaviour we saw? Thanks, Gary -- http://gbenson.net/