From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82479 invoked by alias); 18 Feb 2016 16:03:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 82469 invoked by uid 89); 18 Feb 2016 16:03:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:719, ESA, esa, HContent-Transfer-Encoding:8bit X-HELO: e06smtp16.uk.ibm.com Received: from e06smtp16.uk.ibm.com (HELO e06smtp16.uk.ibm.com) (195.75.94.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Thu, 18 Feb 2016 16:03:41 +0000 Received: from localhost by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 18 Feb 2016 16:03:37 -0000 Received: from d06dlp02.portsmouth.uk.ibm.com (9.149.20.14) by e06smtp16.uk.ibm.com (192.168.101.146) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 18 Feb 2016 16:03:35 -0000 X-IBM-Helo: d06dlp02.portsmouth.uk.ibm.com X-IBM-MailFrom: uweigand@de.ibm.com X-IBM-RcptTo: gdb-patches@sourceware.org Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 75FCB2190061 for ; Thu, 18 Feb 2016 16:03:19 +0000 (GMT) Received: from d06av11.portsmouth.uk.ibm.com (d06av11.portsmouth.uk.ibm.com [9.149.37.252]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u1IG3Yx73342708 for ; Thu, 18 Feb 2016 16:03:34 GMT Received: from d06av11.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av11.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u1IG3X69019901 for ; Thu, 18 Feb 2016 09:03:34 -0700 Received: from oc7340732750.ibm.com (dyn-9-152-213-148.boeblingen.de.ibm.com [9.152.213.148]) by d06av11.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u1IG3XZZ019895; Thu, 18 Feb 2016 09:03:33 -0700 Received: by oc7340732750.ibm.com (Postfix, from userid 500) id 427426B9A; Thu, 18 Feb 2016 17:03:33 +0100 (CET) Subject: Re: [PATCH 2/2] gdb/s390: Fill guess_tracepoint_registers hook. To: koriakin@0x04.net (=?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?=) Date: Thu, 18 Feb 2016 16:03:00 -0000 From: "Ulrich Weigand" Cc: arnez@linux.vnet.ibm.com, gdb-patches@sourceware.org, koriakin@0x04.net (=?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?=) In-Reply-To: <1455791730-28225-2-git-send-email-koriakin@0x04.net> from "=?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?=" at Feb 18, 2016 11:35:30 AM MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-Id: <20160218160333.427426B9A@oc7340732750.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16021816-0025-0000-0000-00000908F085 X-SW-Source: 2016-02/txt/msg00546.txt.bz2 Marcin Kościelnicki wrote: > * s390-linux-tdep.c (s390_guess_tracepoint_registers): New function. > (s390_gdbarch_init): Fill guess_tracepoint_registers hook. I think it would be better to also initialize PSWM to a valid value, in particular since on 64-bit the addressing mode bits are actually in the PSWM instead of the PSWA (and at least in principle even GDB itself occasionally may check the addressing mode bits). A default valid value for PSWM would be 0x070d0000UL in ESA mode 0x0705000180000000UL in zArchitecture mode (64-bit addressing mode) Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com