From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65304 invoked by alias); 18 Feb 2016 15:58:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 65290 invoked by uid 89); 18 Feb 2016 15:58:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: e06smtp10.uk.ibm.com Received: from e06smtp10.uk.ibm.com (HELO e06smtp10.uk.ibm.com) (195.75.94.106) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Thu, 18 Feb 2016 15:58:50 +0000 Received: from localhost by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 18 Feb 2016 15:58:46 -0000 Received: from d06dlp03.portsmouth.uk.ibm.com (9.149.20.15) by e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 18 Feb 2016 15:58:45 -0000 X-IBM-Helo: d06dlp03.portsmouth.uk.ibm.com X-IBM-MailFrom: uweigand@de.ibm.com X-IBM-RcptTo: gdb-patches@sourceware.org Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 4E2F51B08069 for ; Thu, 18 Feb 2016 15:59:02 +0000 (GMT) Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u1IFwjc55570826 for ; Thu, 18 Feb 2016 15:58:45 GMT Received: from d06av08.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u1IFwiph016316 for ; Thu, 18 Feb 2016 08:58:44 -0700 Received: from oc7340732750.ibm.com (dyn-9-152-213-148.boeblingen.de.ibm.com [9.152.213.148]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u1IFwiXm016306; Thu, 18 Feb 2016 08:58:44 -0700 Received: by oc7340732750.ibm.com (Postfix, from userid 500) id 0D7D96B9A; Thu, 18 Feb 2016 16:58:44 +0100 (CET) Subject: Re: [PATCH] gdb: Add guess_tracepoint_registers hook to gdbarch. To: koriakin@0x04.net (=?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?=) Date: Thu, 18 Feb 2016 15:58:00 -0000 From: "Ulrich Weigand" Cc: lgustavo@codesourcery.com, arnez@linux.vnet.ibm.com, gdb-patches@sourceware.org In-Reply-To: <56C5E636.1050107@0x04.net> from "=?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?=" at Feb 18, 2016 04:41:42 PM MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-Id: <20160218155844.0D7D96B9A@oc7340732750.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16021815-0041-0000-0000-0000075691FD X-SW-Source: 2016-02/txt/msg00544.txt.bz2 Marcin Kościelnicki wrote: > On 18/02/16 16:40, Ulrich Weigand wrote: > > I don't think you actually need this include, do you? > > > > Otherwise, this patch is OK. > > > > Bye, > > Ulrich > > > > I do, the default_guess_tracepoint_registers function is declared there, > and gdbarch.c uses it. Ah, right. You should probably move the prototype to arch-utils.h (and then the implementation to arch-utils.c) to go with the other default_ functions. Since gdbarch.h is included everywhere, we try to avoid having it include other headers as far as possible. Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com