From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41050 invoked by alias); 18 Feb 2016 15:40:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41014 invoked by uid 89); 18 Feb 2016 15:40:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: e06smtp06.uk.ibm.com Received: from e06smtp06.uk.ibm.com (HELO e06smtp06.uk.ibm.com) (195.75.94.102) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Thu, 18 Feb 2016 15:40:35 +0000 Received: from localhost by e06smtp06.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 18 Feb 2016 15:40:31 -0000 Received: from d06dlp03.portsmouth.uk.ibm.com (9.149.20.15) by e06smtp06.uk.ibm.com (192.168.101.136) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 18 Feb 2016 15:40:29 -0000 X-IBM-Helo: d06dlp03.portsmouth.uk.ibm.com X-IBM-MailFrom: uweigand@de.ibm.com X-IBM-RcptTo: gdb-patches@sourceware.org Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 7752A1B08070 for ; Thu, 18 Feb 2016 15:40:46 +0000 (GMT) Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u1IFeTlv8258034 for ; Thu, 18 Feb 2016 15:40:29 GMT Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u1IFeSHK001668 for ; Thu, 18 Feb 2016 08:40:29 -0700 Received: from oc7340732750.ibm.com (dyn-9-152-213-148.boeblingen.de.ibm.com [9.152.213.148]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u1IFeShW001665; Thu, 18 Feb 2016 08:40:28 -0700 Received: by oc7340732750.ibm.com (Postfix, from userid 500) id 870066B9A; Thu, 18 Feb 2016 16:40:28 +0100 (CET) Subject: Re: [PATCH] gdb: Add guess_tracepoint_registers hook to gdbarch. To: koriakin@0x04.net (=?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?=) Date: Thu, 18 Feb 2016 15:40:00 -0000 From: "Ulrich Weigand" Cc: lgustavo@codesourcery.com, arnez@linux.vnet.ibm.com, gdb-patches@sourceware.org, koriakin@0x04.net (=?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?=) In-Reply-To: <1455795901-1183-1-git-send-email-koriakin@0x04.net> from "=?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?=" at Feb 18, 2016 12:45:01 PM MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-Id: <20160218154028.870066B9A@oc7340732750.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16021815-0025-0000-0000-000005EDBFD5 X-SW-Source: 2016-02/txt/msg00542.txt.bz2 Marcin Kościelnicki wrote: > * gdbarch.c: Regenerate. > * gdbarch.h: Regenerate. > * gdbarch.sh: Add guess_tracepoint_registers hook, include > tracepoint.h. > * tracefile.c (tracefile_fetch_registers): Use the new gdbarch hook. > * tracepoint.c (default_guess_tracepoint_registers): New function. > * tracepoint.h (default_guess_tracepoint_registers): New prototype. > #include "observer.h" > #include "regcache.h" > #include "objfiles.h" > +#include "tracepoint.h" I don't think you actually need this include, do you? Otherwise, this patch is OK. Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com