From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8245 invoked by alias); 9 Feb 2016 11:58:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8224 invoked by uid 89); 9 Feb 2016 11:58:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 09 Feb 2016 11:58:25 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D3651116556; Tue, 9 Feb 2016 06:58:23 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id wUe7v9rF1jqr; Tue, 9 Feb 2016 06:58:23 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 779BA116543; Tue, 9 Feb 2016 06:58:23 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 5E2DB406C6; Tue, 9 Feb 2016 15:58:19 +0400 (RET) Date: Tue, 09 Feb 2016 11:58:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: "Metzger, Markus T" , "gdb-patches@sourceware.org" Subject: Re: [PATCH v2 2/3] frame: use get_prev_frame_always in skip_tailcall_frames Message-ID: <20160209115819.GH15342@adacore.com> References: <1454681922-2228-1-git-send-email-markus.t.metzger@intel.com> <1454681922-2228-2-git-send-email-markus.t.metzger@intel.com> <20160207130057.GE20874@adacore.com> <56B9D08F.6060507@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56B9D08F.6060507@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2016-02/txt/msg00222.txt.bz2 > > I modified an existing test case to cover the changes. GDB dies with the modified > > test and without the changes to skip_tailcall_frames. This also showed another place > > where we want to use get_prev_frame_always. > > > > Here's the modified version of this patch: > > Thanks. Could you do the limiting test in e.g., gdb.base/finish.exp > and gdb.base/return.exp, so that it'd be covered on all archs? I was going to ask the very same :-). The fact that adding your test showed we missed a spot raised the question as to how much of the initial patch we were testing :). -- Joel