From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25785 invoked by alias); 26 Jan 2016 12:39:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25771 invoked by uid 89); 26 Jan 2016 12:39:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy=sk:type_co, me!, our X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 26 Jan 2016 12:39:44 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id B7AC7116487; Tue, 26 Jan 2016 07:39:42 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id W9pnJxaCwUkD; Tue, 26 Jan 2016 07:39:42 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 5FC581162D5; Tue, 26 Jan 2016 07:39:42 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 5E66D40C2A; Tue, 26 Jan 2016 16:39:38 +0400 (RET) Date: Tue, 26 Jan 2016 12:39:00 -0000 From: Joel Brobecker To: Kevin Buettner Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] rx: Treat scalars larger than 8 bytes as aggregates in rx_push_dummy_call Message-ID: <20160126123938.GK5146@adacore.com> References: <20160123161811.1c92dd3d@pinnacle.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160123161811.1c92dd3d@pinnacle.lan> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2016-01/txt/msg00650.txt.bz2 Hi Kevin, > gdb/ChangeLog: > > * rx-tdep.c (rx_push_dummy_call): Treat scalars larger than 8 > bytes as aggregates. I'll trust you on RX matters, and the contents of the message seems to indicate that you would have tested the change using our testsuite, so... OK with me! :-) > --- > gdb/rx-tdep.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/gdb/rx-tdep.c b/gdb/rx-tdep.c > index 2732608..904aebd 100644 > --- a/gdb/rx-tdep.c > +++ b/gdb/rx-tdep.c > @@ -813,7 +813,8 @@ rx_push_dummy_call (struct gdbarch *gdbarch, struct value *function, > struct_addr); > } > else if (TYPE_CODE (arg_type) != TYPE_CODE_STRUCT > - && TYPE_CODE (arg_type) != TYPE_CODE_UNION) > + && TYPE_CODE (arg_type) != TYPE_CODE_UNION > + && arg_size <= 8) > { > /* Argument is a scalar. */ > if (arg_size == 8) -- Joel