From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70243 invoked by alias); 21 Jan 2016 10:33:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 70232 invoked by uid 89); 21 Jan 2016 10:33:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy=cool! X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 21 Jan 2016 10:33:36 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 85F0111732A; Thu, 21 Jan 2016 05:33:34 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ATDIicgZzXtd; Thu, 21 Jan 2016 05:33:34 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 4654F1173B0; Thu, 21 Jan 2016 05:33:30 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 3E2D445017; Thu, 21 Jan 2016 14:33:21 +0400 (RET) Date: Thu, 21 Jan 2016 10:33:00 -0000 From: Joel Brobecker To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Fix regression introduced in "break *" by explicit location patches Message-ID: <20160121103321.GD5146@adacore.com> References: <20150805232802.21646.88440.stgit@valrhona.uglyboxes.com> <20150805232951.21646.67733.stgit@valrhona.uglyboxes.com> <20151214071113.GA6230@adacore.com> <566F2CF1.1030003@redhat.com> <20151215133948.GA7938@adacore.com> <20160117153229.GF4059@adacore.com> <569D591C.5000509@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <569D591C.5000509@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2016-01/txt/msg00507.txt.bz2 > On 01/17/2016 07:32 AM, Joel Brobecker wrote: > > What do you think of the attached patch? There is also a testcase, > > which is slightly different from the scenario that triggered this > > exchange, but which also has the advantage of not requiring PIE, > > which makes the test a little more universal, I think. > > This looks great to me. I say go for it. > > [Wow, you found a non-PIE reproducer. Way cool!] :-). thanks for the review, Keith. I just pushed the patch. > PS. I also note there was a "save breakpoints" bug related to this bug, > too. I'll work on a separate submission for that. This is definitely > should have some test coverage! That would be nice indeed. -- Joel