From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66840 invoked by alias); 15 Jan 2016 17:45:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 66823 invoked by uid 89); 15 Jan 2016 17:44:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=bennett X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 15 Jan 2016 17:44:56 +0000 Received: from vapier.lan (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id 53DC1340940; Fri, 15 Jan 2016 17:44:53 +0000 (UTC) Date: Fri, 15 Jan 2016 17:45:00 -0000 From: Mike Frysinger To: Andrew Bennett Cc: Maciej Rozycki , "gdb-patches@sourceware.org" , Steve Ellcey Subject: Re: [PATCH] Add micromips support to the MIPS simulator Message-ID: <20160115174453.GA4894@vapier.lan> Mail-Followup-To: Andrew Bennett , Maciej Rozycki , "gdb-patches@sourceware.org" , Steve Ellcey References: <0DA23CC379F5F945ACB41CF394B9827720F51185@LEMAIL01.le.imgtec.org> <20150224054441.GA6655@vapier> <0DA23CC379F5F945ACB41CF394B98277211129DE@LEMAIL01.le.imgtec.org> <20150917044236.GB6834@vapier.lan> <0DA23CC379F5F945ACB41CF394B9827721126A60@LEMAIL01.le.imgtec.org> <20150925140742.GD21570@vapier.lan> <0DA23CC379F5F945ACB41CF394B98277211271C5@LEMAIL01.le.imgtec.org> <0DA23CC379F5F945ACB41CF394B9827761B7E470@LEMAIL01.le.imgtec.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZcaUvQ23gCOmDTXi" Content-Disposition: inline In-Reply-To: <0DA23CC379F5F945ACB41CF394B9827761B7E470@LEMAIL01.le.imgtec.org> X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg00327.txt.bz2 --ZcaUvQ23gCOmDTXi Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1008 On 15 Jan 2016 16:22, Andrew Bennett wrote: > > As a microMIPS engine is not included in a mips-linux-gnu build the file > > supposed to provide `micromips_instruction_decode' is not generated or > > compiled, whereas `delayslot_micromips' (and a bunch of other functions) > > is built unconditionally. > >=20 > > Restricting the affected functions to microMIPS processors only has fi= xed > > the build problem for me, see the patch below. I have not verified it > > further though, will you be able to look into it soon? >=20 > Hi Maciej, >=20 > The patch looks good, I noticed that the FMT_MICROMIPS, FMT_MICROMIPS_CVT= _D > and FMT_MICROMIPS_CVT_S functions also needed fixing. I have built it fo= r the=20 > mips-elf, mips-linux-gnu and mips-mti-elf targets and they all build succ= essfully. > The updated patch and ChangeLog is below. >=20 > Ok to commit? looks fine to me. note that this is PR sim/19441 (which is assigned to you), so you should note that in the ChangeLog/commit message. -mike --ZcaUvQ23gCOmDTXi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWmTAVAAoJEEFjO5/oN/WB0TUP/3zKU5BHzRAnpyKXnvxKVf5a uu9lZdFQpSPOmk+WB6vi8/XtBKlo51Dc97N6Px6s8p9Oo2mq+0hJ/FzegdyIgavp 3SZ5kPulhPzcwDyrwnv+JKegBIXq6OHvbx3HKqx8NE+xA75Uj2YO6XJVxtIR/gIN yy0GqJcA2VM78yvm6sJs13sWntZ5wM2/XZf36fh9R1fxenAgTTO4Ba3YFgfCZ42m +sqNUK70Q16TMnv8O8v112Pqq5O7FoFaUaToEtoj8UvSWrr9vfK9nN7epTxsp9hm 0jI0My8WCoOuDEpyYV4W31qku0Ezm2mptW0Z70uBGVHzdQylm3kXMA/Dr7u09VnJ CLk7jrXsCqXLjRzKMuvCzjV6uhZNwhF+A/s8vGaSHvNrViewTn99HwO2PVPDArNv UUzEW2Ze4zQeAiODdE/G4Bg9At8ElVHckiIFk6EdxOk+YLmoxdb+3NFihqDSFkEb aS4krhCqSQI85qoXLukcfQ2EvyiK1j4TiZJgvb0elw6PL7zP+N9KkW6AEiINv/7e nC0pLiQXDeTIuoQteqmEQNN8aBWB6sgrzmsaHPskOhSikvyx5f5JC0Bd8VPgXq01 23btCVmzjzb03rquSglbYULDwYo/1xGUXSKNUIkZ9CTTaXFF7kOYUny7mMOX5/ab 1u4UNM5JDIgJcQVWptie =QKjv -----END PGP SIGNATURE----- --ZcaUvQ23gCOmDTXi--