Re: [PATCH] Add a new format letter to dump instructions backward

Toshihito Kikuchi
2016-01-26T05:39:50Z

Thank you for the great suggestion.

I also agree that #3, adding the support for a negative number, looks reasonable. I'll get back to this thread when the code is ready.

To answer the question from Paul, Pedro's guess is correct. I used symbol's line info to solve a correct frame. And yes, this feature does not work without debug information unfortunately. Since I'm not familiar with architectures other than x86, let me finish this work in the current approach first. If there are architectures where instruction length is fixed, I think I can add them later.

> Adding some tests would be great. Also, the documentation
> will need to be updated.
>
> If you haven't yet, please take a look at:
> https://sourceware.org/gdb/wiki/ContributionChecklist
Thank you for pointing to this. I looked at only gdb/CONTRIBUTE and didn't reach this. Tests and doc updates will be included in next patch.

Thanks,
Toshihito