Re: [PATCH][RX] instructions test set.

Mike Frysinger
2015-12-25T17:04:19Z

[-- Attachment #1: Type: text/plain, Size: 817 bytes --]

On 25 Dec 2015 23:19, Yoshinori Sato wrote:
> --- /dev/null
> +++ b/sim/testsuite/sim/rx/abs.s
> @@ -0,0 +1,25 @@
> +# RX testcase for abs
> +# mach: all

i think you want to use "rx rxv2" instead of "all"

> --- /dev/null
> +++ b/sim/testsuite/sim/rx/allinsn.exp
> @@ -0,0 +1,67 @@
> +# Renesas RX simulator testsuite
> +
> +set all "rx rxv2"
> +set global_ld_options "-Ttext=0x01000000 --defsym __stack=0x01800000"

move these inside of the "if" statement

> +if [istarget rx-*-*] then {

drop the "then" keyword

> + run_sim_test abs.s $all

instead of listing them all out, look at how testsuite/sim/msp430/allinsn.exp
is written using a loop and glob. i think passing down $all for all of the
tests should be fine, even the later ones where you pass rxv2. the framework
should skip things as needed.
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]