From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94288 invoked by alias); 25 Dec 2015 16:57:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 94278 invoked by uid 89); 25 Dec 2015 16:57:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=reg_names, H*c:HHH, HTo:D*jp X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 25 Dec 2015 16:57:10 +0000 Received: from vapier.lan (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id 5CE543405D5; Fri, 25 Dec 2015 16:57:08 +0000 (UTC) Date: Fri, 25 Dec 2015 16:57:00 -0000 From: Mike Frysinger To: Yoshinori Sato Cc: gdb-patches@sourceware.org Subject: Re: [PATCH][RX] v2 instructions support Message-ID: <20151225165708.GS25803@vapier.lan> Mail-Followup-To: Yoshinori Sato , gdb-patches@sourceware.org References: <1451053193-27204-1-git-send-email-ysato@users.sourceforge.jp> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HFD/Dq8JdnjNvyuv" Content-Disposition: inline In-Reply-To: <1451053193-27204-1-git-send-email-ysato@users.sourceforge.jp> X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00497.txt.bz2 --HFD/Dq8JdnjNvyuv Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 3271 On 25 Dec 2015 23:19, Yoshinori Sato wrote: > +rxfp_fsqrt (fp_t fa) > ... > + tprintf("sqrt(%g) =3D %g\n", da, sqrt(da)); > + > + double_to_fp (sqrt(da), &c); needs space before the ( -- comes up three times here > +void > +get_acc (int id, acc_t *acc) > { > + if (id >=3D 2) > + abort (); > + *acc =3D regs.r_acc[id]; > + if (trace > 0) > + printf ("get_reg (%s) =3D %08x%016lx\n", reg_names[acc0 + id], acc->= hi, acc->lo); don't you want to use tprintf ? > +put_acc (int id, acc_t *acc) > { > + if (id >=3D 2) > + abort (); > + if (trace > 0) > + printf ("put_reg (%s) =3D %08x%016lx\n", reg_names[acc0 + id], acc->= hi, acc->lo); same here > + { > + if (tag) { printf (tag); tag =3D 0; } need to unwrap this: if (tag) { printf (tag); tag =3D NULL; } > +#define MULADD(val, s) \ > +{ \ > + get_acc (opcode->op[0].reg - 32, &acc); \ these macro bodies are indented by one space when they should start at two > +#define MULSUB(val, s) \ > +{ \ > + get_acc (opcode->op[0].reg - 32, &acc); \ same here > +#define MULACC(val, s) \ > +{ \ > + sll =3D val; \ same here > +#define RAC(add, pl, ml) \ > +{ \ > + get_acc (opcode->op[0].reg - 32, &acc); \ and here > + case RXO_emaca: > + MULADD((long long)GS2 () * (long long)GS (), 0) > + > + case RXO_emsba: > + MULSUB((long long)GS2 () * (long long)GS (), 0) space before the ( > + tprintf ("(int) %g =3D %d\n", int2float(ma), mb); space before the ( -- see int2float > + tprintf ("(int) %g =3D %d\n", int2float(ma), mb); same here > case RXO_machi: > + MULADD((long long)(signed short)(GS() >> 16) * > + (long long)(signed short)(GS2 () >> 16), 16) > + > + case RXO_maclh: > + MULADD((long long)(signed short)(GS()) * > + (long long)(signed short)(GS2 () >> 16), 16) >=20 > case RXO_maclo: > + MULADD((long long)(signed short)(GS()) * > + (long long)(signed short)(GS2 ()), 16) comes up a few times here w/ MULADD & GS > + case RXO_msbhi: > + MULSUB((long long)(signed short)(GS() >> 16) * > + (long long)(signed short)(GS2 () >> 16), 16) > + > + case RXO_msblh: > + MULSUB((long long)(signed short)(GS()) * > + (long long)(signed short)(GS2 () >> 16), 16) > + > + case RXO_msblo: > + MULSUB((long long)(signed short)(GS()) * > + (long long)(signed short)(GS2 ()), 16) >=20 > case RXO_mulhi: > + MULACC((long long)(signed short)(GS() >> 16) * > + (long long)(signed short)(GS2 () >> 16), 16) > + case RXO_mullh: > + MULACC((long long)(signed short)(GS()) * > + (long long)(signed short)(GS2 () >> 16), 16) >=20 > case RXO_mullo: > + MULACC((long long)(signed short)(GS()) * > + (long long)(signed short)(GS2 ()), 16) and here w/ MULSUB & GS & MULACC > case RXO_racw: > + RAC(0x80000000ULL, 0x00007fff00000000ULL, 0xffff800000000000ULL) > + > + case RXO_rdacw: > + RAC(0, 0x00007fff00000000ULL, 0xffffffff80000000ULL) > + > + case RXO_racl: > + RAC(0x80000000ULL, 0x7fffffff00000000ULL, 0xffffffff80000000ULL) > +=20=20=20=20=20=20 > + case RXO_rdacl: > + RAC(0, 0x7fffffff00000000ULL, 0xffff800000000000ULL) and here w/ RAC -mike --HFD/Dq8JdnjNvyuv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWfXVkAAoJEEFjO5/oN/WBroQQAIZMTea2ikoJjsKPO+S5qyh0 FnWoUHP2X4KE88zp0+6C+GTSLaSkxw749YrPamxNrXzk63O5Zn8LBeSuejffSVKD +EmLYAzyqCv5CbMm+QtiJ1OuYEycnRqLwLCOQJsESdTkgNH377YtCzeF5SQV/4I6 zBDwHN1C168hbIMKTOvgtLe5ecLz2WHvm/84LJwy18dGex8BqWuZ5sToNzrBWQAi d31ipzFRswwzFtYgjK+NpaZcj0nyQakdDovyf5a3LAWlQGYLEnm+034TQenUtjTk BPuH5zaQI458LhnsLv0dcUvlYOnV34p4KjJ2btsRjR+4ESMdWKqpU8gjk+Hgc2mn RnMj+BmnHCKDPtU5owXOZ0OF9VC3Gf8POZhI4yG4upX/q1mX4K5VkCZYjGQrEQ13 OAK02WCM5WwNy8Ok8szqCjZpVIHgvIl+44nKddPbzD7sTPXoX7h1pVanoAEH2u2w DPqJAi5/WzZR1GpRgd4J4dvfImrpFNUpN307dgYnR2zVe1M10xyzUUfvngkaN19E p1f+iK7XQ0YMy9Fin21OBopPLS25qDuPmw62bUCnF7I3xS5n9uDp0cgXSktRyilR m3yIkJRzrx/jw8jevyntYMmyGL8PsRmxT2QqMkXoD7gsaJ+K8UqDXBOfNynEMdk5 CcEJ8OnyvC98fee2N8l4 =9yiO -----END PGP SIGNATURE----- --HFD/Dq8JdnjNvyuv--