From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28092 invoked by alias); 23 Dec 2015 15:06:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28078 invoked by uid 89); 23 Dec 2015 15:06:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=metzger, 2015-12-23 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 23 Dec 2015 15:06:46 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id BCA741167DD; Wed, 23 Dec 2015 10:06:44 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id tfbmtFRrvzrh; Wed, 23 Dec 2015 10:06:44 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 4E94E1167DB; Wed, 23 Dec 2015 10:06:44 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 4339446BAD; Wed, 23 Dec 2015 19:06:40 +0400 (RET) Date: Wed, 23 Dec 2015 15:06:00 -0000 From: Joel Brobecker To: Markus Metzger Cc: palves@redhat.com, gdb-patches@sourceware.org Subject: Re: [PATCH] btrace: do not return out of TRY/CATCH Message-ID: <20151223150640.GA7509@adacore.com> References: <1450881004-31154-1-git-send-email-markus.t.metzger@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1450881004-31154-1-git-send-email-markus.t.metzger@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-12/txt/msg00467.txt.bz2 > 2015-12-23 Markus Metzger > > gdb/ > * btrace.c (btrace_pt_readmem_callback): Do not return in TRY/CATCH. > > testsuite/ > * gdb.btrace/dlopen.exp: New. > * gdb.btrace/dlopen.c: New. > * gdb.btrace/dlopen-dso.c: New. Looks good to me (and I verified that the TRY/CATCH documentation mentions that we should not goto or return out of it). Thanks! -- Joel