Re: [PATCH] Per-inferior thread IDs

Joel Brobecker
2015-12-18T17:53:15Z

> However, before I dig deeper, I thought I'd post this for feedback.

FWIW, I think that this is a fairly nice way of addressing the problem!

The only question I have is that I'm a little unclear as to what
it will look like with GDB/MI. From what I can tell, there is no
real change at all, meaning that the "thread-id" is the thread's
global ID. But perhaps it wouuld be nice to add an extra field
giving the thread's ID in string form. Newer IDEs knowing about
this new feature would then have an easy way to present the list
of threads using the same representation as the one we see with
the CLI interface. Just a thought...

Another way would be to provide the per-inferior-thread-id in numeric
form, which should be sufficient, since I think the inferior-id is
already provided. It has a cleaner feel to it, but on the other hand,
it forces the IDEs to rebuild the thread ID by hand - which is not so
simple, since we have this exception where if there is one inferior
whose ID is 1, we don't use the composite thread ID.

That being said, maybe the IDEs don't even (need to) display
that ID... So we could also leave that question open for debate
when the need actually materializes...

--
Joel