Re: [PATCH] Per-inferior thread IDs

Eli Zaretskii
2015-12-18T19:36:22Z

> Date: Fri, 18 Dec 2015 18:11:06 +0000
> From: Pedro Alves <palves@redhat.com>
> CC: gdb-patches@sourceware.org
>
> >> +@kindex thread @var{thread-id}
> >> +@item thread @var{thread-id}
> >> +Make thread ID @var{thread-id} the current thread. The command
> >> +argument @var{thread-id} is the internal @value{GDBN} thread ID, as
> > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> >> shown in the first field of the @samp{info threads} display.
> >
> > Why not use "qualified thread ID" here?
>
> This is not always inferior-qualified. It depends on whether you
> created a second inferior, as described earlier in the thread IDs
> description:
>
> Until you create a second inferior, @value{GDBN} does not show the
> @var{inferior-num} part of thread IDs, even though you can always use
> the full @var{inferior-num}.@var{thread-num} form to refer to threads
> of inferior 1, the initial inferior.
>
> Should I drop "internal", perhaps?

Yes, I think so.

> In any case, I've added an example now:
>
> +Make thread ID @var{thread-id} the current thread. The command
> +argument @var{thread-id} is the internal @value{GDBN} thread ID, as
> +shown in the first field of the @samp{info threads} display, with or
> +without an inferior qualifier (e.g., @samp{2.1} or @samp{1}).

An example always helps, so this is even better.

> Thank you very much for the review and suggestions thus far.
> Here's an updated docs patch. Let me know how it looks.

LGTM, thanks.