From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43953 invoked by alias); 5 Dec 2015 22:41:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43937 invoked by uid 89); 5 Dec 2015 22:41:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 X-HELO: mail-wm0-f48.google.com Received: from mail-wm0-f48.google.com (HELO mail-wm0-f48.google.com) (74.125.82.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sat, 05 Dec 2015 22:41:34 +0000 Received: by wmww144 with SMTP id w144so106850860wmw.0 for ; Sat, 05 Dec 2015 14:41:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=Bgwqh4hc3MnYi2aC9pcOlDaXDJGsZjhPQ2Q3SCBniDQ=; b=N9JRHcI91xfosJ7QLkPz5QoNO98BP+JITm/wuj+Wwk7wwSw5XAqdb0wcqeQk23Ge9I DkTP/0bM1IJSqybqDOHGtBiPMHZ2QqZumzDgUnuc60/1YVkJNJnUBc5fC2mRzJg0QENZ CjbZXQH5sXhnJpS8NxzJGyPQh0R7WtCBenZSavmTolNwB0eM83LUn+jPYDp+OLtaL2wl /R4eMAWVByPeBrstOW85fXlzT2YNJbOhvdBfgzwbebuzJiGjbFFyFVHs4HaCRaDDTNpY J5/pAiDAq6sd2o4U0POsssTrMMv+q6Vs1HPnASeLXzAG0fk9CPCOmt/HUHfcB5lFmWGZ rtOA== X-Gm-Message-State: ALoCoQliCvJrXfheecXAVNPYBiKT5XeKjxaqQIPBUzBbsvKwXyqfNQw1zNSuAm7gc5hwcr0t9eHu X-Received: by 10.194.58.142 with SMTP id r14mr29288958wjq.37.1449355291478; Sat, 05 Dec 2015 14:41:31 -0800 (PST) Received: from localhost (host86-138-95-213.range86-138.btcentralplus.com. [86.138.95.213]) by smtp.gmail.com with ESMTPSA id c194sm9487450wmd.13.2015.12.05.14.41.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 05 Dec 2015 14:41:30 -0800 (PST) Date: Sat, 05 Dec 2015 22:41:00 -0000 From: Andrew Burgess To: Ruslan Kabatsayev Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH][PR 18702] Fix wrong output of x87 registers due to truncation to double on amd64 Message-ID: <20151205224129.GO4625@embecosm.com> References: <564F998D.5080406@gmail.com> <5660357F.4030605@redhat.com> <5661AD07.5090002@redhat.com> <5661B2A7.6020005@redhat.com> <5661BACA.50909@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5661BACA.50909@gmail.com> X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00108.txt.bz2 * Ruslan Kabatsayev [2015-12-04 19:09:46 +0300]: > When `info float` is used on an AMD64 system, GDB prints floating-point > values of x87 registers with raw contents like 0x361a867a8e0527397ce0 or > 0xc4f988454a1ddd3cfdab wrongly. This happens due to truncation to double, > after which the former becomes 0.0, and the latter becomes negative infinity. > This is caused by failed detection of x86-64 host, which results in setting > gdb_host_{float,double,long_double}_format to zeros. > This commit fixes this misdetection, and adds a test to make sure future > commits don't introduce a regression here. > > gdb/ChangeLog: > > * configure.host: Fix detection of x86_64 host when setting > floatformats. > * testsuite/gdb.arch/i386-float.S: Add a regression test for the fix. > * testsuite/gdb.arch/i386-float.exp: Add checking of the test results. There's a separate ChangeLog in the gdb/testsuite directory, so you need to split your entry over these two files. And remember files names in the testsuite ChangeLog don't need to have the testsuite/ prefix. Thanks, Andrew