From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79610 invoked by alias); 20 Nov 2015 09:13:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 79599 invoked by uid 89); 20 Nov 2015 09:13:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 20 Nov 2015 09:13:29 +0000 Received: from vapier.lan (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id 1A82E340A5D; Fri, 20 Nov 2015 09:13:27 +0000 (UTC) Date: Fri, 20 Nov 2015 09:13:00 -0000 From: Mike Frysinger To: Nick Clifton Cc: gdb-patches@sourceware.org Subject: Re: RFA: AArch64 sim Message-ID: <20151120091326.GC23754@vapier.lan> Mail-Followup-To: Nick Clifton , gdb-patches@sourceware.org References: <87vbe8hvfo.fsf@redhat.com> <87y4ih8ij4.fsf@redhat.com> <20150716151902.GE5641@vapier> <55A90CBA.40007@redhat.com> <20151110073245.GN5154@vapier.lan> <564DE205.10501@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="l76fUT7nc3MelDdI" Content-Disposition: inline In-Reply-To: <564DE205.10501@redhat.com> X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00412.txt.bz2 --l76fUT7nc3MelDdI Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-length: 1372 On 19 Nov 2015 14:51, Nick Clifton wrote: > + return cpu->gr[reg_num(reg)].u64; you should scan the code and make sure it's doing func (foo) everywhere. i noticed a few places like this where it's not. > +sim_fetch_register (SIM_DESC sd, int regno, unsigned char *buf, int length) > +sim_store_register (SIM_DESC sd, int regno, unsigned char *buf, int length) please convert to CPU_REG_FETCH/CPU_REG_STORE instead of defining these. look at commit 9ef4651c4930423f9678832f793343059d4ef9ad as an easy example. just ignore the Makefile changes as the common core handles that now. > +SIM_OBJS = \ > ... > + sim-reason.o \ > + sim-stop.o you can delete these two from your Makefile as the common core adds them. > +#define TRACE_MEM_WRITES (1 << 0) > +#define TRACE_REG_WRITES (1 << 1) > +#define TRACE_FUNCTIONS (1 << 2) > +#define TRACE_MISC (1 << 3) > +#define TRACE_ALL ((1 << 4) - 1) unused -> delete > +#define TST( _flag ) (aarch64_test_CPSR_bit (cpu, _flag)) > +#define IS_SET( _X ) ( TST (( _X ))) > +#define IS_CLEAR( _X ) (!TST (( _X ))) drop the weird spacing here > +report_and_die (sim_cpu *cpu, int exitCode) > +{ > + TRACE_EVENTS (cpu, "Exiting simulator with exit code %d", exitCode); > + exit (exitCode); > +} pretty sure you can use one of the existing abort funcs instead of defining your own. like sim_engine_abort. -mike --l76fUT7nc3MelDdI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWTuQ2AAoJEEFjO5/oN/WBKJkP/j7K5hB33FYhP3YJl8kD4p5M qFSa21ufFZz/Vu/oWEARM2fnm1bloiXnz+Mt2tHoM0adaJ7+RDoaE0K8YzuLFPRp r6rmYjW/eyOZME/1rNR6tCn0EXv8wmvCrQ/LRwUuA1REz7JBZhtakhnfk90zzSnh BJwwwavdfz+rhefKFryKSaV4hLYaCr2nutq/MFdjSd6XusLGJvJDu1vZp4TKg3kN GPW4e5BrSWfJJesBU3+mtel1zsGJwEMBs/Rv3soZ7a1Dd72+FPpwsAW+fsPSBl9F 8HUC8NLIdTmQmOnKvW0D/An4vCwMp8jz50Wxgn2YjzzUBWKgpaMpprVacFxsOKcw uPd+wQHFTaQuxYAMramiYxq0UeHHWVVQILJ7wfzMlYocbNK4hboygs0c44ADt9gH fklhDODJuG43fPGVC706weFPlK8rbrLmOX2SOqM+uQmTo3r7vTiUPbEmSYTXSaTD iia9vBY3jHdi13PkSwOVQfUnWZw0BSgsXi/NPkhF8/Dwmwy0tMJJRoTdP5cKiyiH xe95IuVmojKf9WovTLrdsPqidTu8dVqvbg97jgiBLudpgklHfbq2SDt1y67dsRUl Wfulkl+7kNg28yk9/7q6ZVmJwItQ4DfNccsUmR6GyR0dRa+ypyOKRHh1jbW0mTtI 40xht88F/fJIpuK/1Iiy =viIg -----END PGP SIGNATURE----- --l76fUT7nc3MelDdI--