From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-127430-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 35942 invoked by alias); 7 Nov 2015 18:12:47 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 35933 invoked by uid 89); 7 Nov 2015 18:12:46 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 07 Nov 2015 18:12:46 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (Postfix) with ESMTPS id 21E5D79	for <gdb-patches@sourceware.org>; Sat,  7 Nov 2015 18:12:45 +0000 (UTC)
Received: from pinnacle.lan (ovpn-113-161.phx2.redhat.com [10.3.113.161])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tA7ICiOB027311	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA256 bits=256 verify=NO)	for <gdb-patches@sourceware.org>; Sat, 7 Nov 2015 13:12:45 -0500
Date: Sat, 07 Nov 2015 18:12:00 -0000
From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] testsuite: Define and use gdb_target_symbol_prefix_flags_asm
Message-ID: <20151107111243.76a58d7d@pinnacle.lan>
In-Reply-To: <20151106062518.60bb68b8@pinnacle.lan>
References: <20151105222822.2f41149f@pinnacle.lan>	<563C761D.9070401@redhat.com>	<20151106062518.60bb68b8@pinnacle.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2015-11/txt/msg00215.txt.bz2

On Fri, 6 Nov 2015 06:25:18 -0700
Kevin Buettner <kevinb@redhat.com> wrote:

> On Fri, 06 Nov 2015 09:42:53 +0000
> Pedro Alves <palves@redhat.com> wrote:
> 
> > On 11/06/2015 05:28 AM, Kevin Buettner wrote:
> >
> > > +proc gdb_target_symbol_prefix_flags {} {
> > > +    set flags [gdb_target_symbol_prefix_flags_asm]
> > > +    regsub {(DSYMBOL_PREFIX=)(.*)$} $flags {\1"\2"} flags
> > > +    return flags
> > 
> > Hmm, I think it'd end up simpler/less magic to remove the
> > indirection through gdb_target_symbol_prefix_flags_asm after all.
> > It's about the same number of worker lines, but no magic regex.
> > Like:
> > 
> > proc gdb_target_symbol_prefix_flags_asm {} {
> >     set prefix [gdb_target_symbol_prefix]
> >     if {$prefix ne ""} {
> > 	return "additional_flags=-DSYMBOL_PREFIX=\"$prefix\""
> >     }
> >     return ""
> > }
> > 
> > WDYT?
> 
> I think you're right.
> 
> I'll make that change later on today and then push it.

I've pushed this change.

Kevin