Re: [PATCH] testsuite: Define and use gdb_target_symbol_prefix_flags_asm

[Kevin Buettner <kevinb@redhat.com>]

On Fri, 06 Nov 2015 09:42:53 +0000
Pedro Alves <palves@redhat.com> wrote:

> On 11/06/2015 05:28 AM, Kevin Buettner wrote:
>
> > +proc gdb_target_symbol_prefix_flags {} {
> > +    set flags [gdb_target_symbol_prefix_flags_asm]
> > +    regsub {(DSYMBOL_PREFIX=)(.*)$} $flags {\1"\2"} flags
> > +    return flags
> 
> Hmm, I think it'd end up simpler/less magic to remove the
> indirection through gdb_target_symbol_prefix_flags_asm after all.
> It's about the same number of worker lines, but no magic regex.
> Like:
> 
> proc gdb_target_symbol_prefix_flags_asm {} {
>     set prefix [gdb_target_symbol_prefix]
>     if {$prefix ne ""} {
> 	return "additional_flags=-DSYMBOL_PREFIX=\"$prefix\""
>     }
>     return ""
> }
> 
> WDYT?

I think you're right.

I'll make that change later on today and then push it.

Thanks again for your help with this.

Kevin