From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6682 invoked by alias); 5 Nov 2015 16:56:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6668 invoked by uid 89); 5 Nov 2015 16:56:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.2 required=5.0 tests=AWL,BAYES_50,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 05 Nov 2015 16:56:17 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 9878E2999D; Thu, 5 Nov 2015 11:56:15 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id eoxu1MpDq3dm; Thu, 5 Nov 2015 11:56:15 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 71CF429579; Thu, 5 Nov 2015 11:56:15 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id D3511446B0; Thu, 5 Nov 2015 08:56:13 -0800 (PST) Date: Thu, 05 Nov 2015 16:56:00 -0000 From: Joel Brobecker To: Keven Boell Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] fort_dyn_array: enable dynamic array of types Message-ID: <20151105165613.GS4009@adacore.com> References: <1446738991-23962-1-git-send-email-keven.boell@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1446738991-23962-1-git-send-email-keven.boell@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-11/txt/msg00188.txt.bz2 Keven, On Thu, Nov 05, 2015 at 04:56:31PM +0100, Keven Boell wrote: > This patch enables dynamic arrays of types in Fortran. > > 2015-03-20 Keven Boell > > * gdbtypes.c (resolve_dyn_properties): New. > (resolve_dynamic_range): Add call to resolve_dyn_properties > to resolve data_location. > (resolve_dynamic_array): Add call to resolve_dyn_properties > to resolve data_location. > (resolve_dynamic_union): Add call to resolve_dyn_properties > to resolve_data_location. > (resolve_dynamic_struct): Add call to resolve_dyn_properties > to resolve_data_location. Adjust address of inner types of > a struct to reflect the offset of the inner's type data_location. > (resolve_dynamic_type_internal): Remove data_location computation. > * value.c (set_value_component_location): Adjust the value address > for single value prints. > (value_primitive_field): Use lazy fetch to re-evaluate a field to > get the actual value. > (value_fetch_lazy): Use address provided by DWARF data_location > attribute if present. > > testsuite/gdb.fortran: > > * vla-type.exp: New file. > * vla-type.f90: New file. This is really not the way I tried to explained how these changes should be submitted. I don't know about others, but I can't understand the reasons for the changes if you don't show me what's happening today, the debugging info, why the debugger is failing, and explain how you are fixing the issue. For instance, I suspect that this patch can be split into smaller, independent patches, which themselves fixes a smaller set of issues. And I'd like to make sure we have a test for each hunk that you're adding. -- Joel