From: Joel Brobecker <brobecker@adacore.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Keven Boell <keven.boell@intel.com>, gdb-patches@sourceware.org
Subject: Re: off-trunk gdb.fortran/dwarf-stride.exp no longer PASSes [Re: [PATCH 0/2] fort_dyn_array: Enable basic Fortran dynamic array support]
Date: Wed, 04 Nov 2015 21:48:00 -0000 [thread overview]
Message-ID: <20151104214815.GR4009@adacore.com> (raw)
In-Reply-To: <20151029223619.GA12147@host1.jankratochvil.net>
> Apparently the VLA patchset is not yet checked-in completely, for example the
> off-trunk patchset formerly contained:
>
> attr = dwarf2_attr (die, DW_AT_string_length, cu);
> if (attr)
> {
> - length = DW_UNSND (attr);
> + if (attr_form_is_block (attr))
> + {
>
> but current FSF GDB HEAD does not yet recognize attr_form_is_block for
> DW_AT_string_length at all so it just cannot work yet.
>
> I will have to apply only remaining parts of the former off-trunk patchset but
> that is sure off-topic for upstream GDB.
Just to be sure - did we regress on something in the master branch?
Or is this just a regression on your branch when you only rely on
the changes that were made on master?
The changes that were first submitted early on in the process were
too big, and I suspect some of them were also OBE, so I asked that
the patches be submitted piecemeal, to allow me to understand why
each change was made. This allowed us to eventually get a good chunk
of the work in, but as you can see, some chunks appear to still be
missing...
--
Joel
next prev parent reply other threads:[~2015-11-04 21:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 12:42 [PATCH 0/2] fort_dyn_array: Enable basic Fortran dynamic array support Keven Boell
2015-07-01 12:42 ` [PATCH 2/2] fort_dyn_array: add basic test coverage Keven Boell
2015-07-21 18:19 ` Joel Brobecker
2015-08-05 13:41 ` Keven Boell
2015-07-01 12:42 ` [PATCH 1/2] fort_dyn_array: add basic fortran dyn array support Keven Boell
2015-07-21 18:05 ` Joel Brobecker
2015-08-05 13:41 ` Keven Boell
2015-08-05 13:47 ` Keven Boell
2015-08-05 20:23 ` Joel Brobecker
2015-08-06 11:42 ` keven.boell
2015-08-20 12:52 ` Joel Brobecker
2015-10-09 11:37 ` Keven Boell
2015-10-22 9:59 ` Joel Brobecker
2016-01-20 10:19 ` Yao Qi
2016-01-22 7:22 ` Keven Boell
2016-01-22 12:40 ` Joel Brobecker
2016-01-22 15:25 ` Yao Qi
2016-01-26 12:34 ` Joel Brobecker
[not found] ` <5613D0DC.3040908@linux.intel.com>
2015-10-22 9:59 ` Joel Brobecker
2015-10-28 15:30 ` off-trunk gdb.fortran/dwarf-stride.exp no longer PASSes [Re: [PATCH 0/2] fort_dyn_array: Enable basic Fortran dynamic array support] Jan Kratochvil
2015-10-28 16:19 ` Jan Kratochvil
[not found] ` <20151028161907.GB4009@adacore.com>
2015-10-30 10:39 ` Jan Kratochvil
2015-11-04 21:48 ` Joel Brobecker [this message]
2015-11-04 22:08 ` Jan Kratochvil
2015-11-05 7:31 ` Keven Boell
2015-11-05 8:22 ` Jan Kratochvil
2015-11-05 16:05 ` Keven Boell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151104214815.GR4009@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=keven.boell@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox