From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83188 invoked by alias); 4 Nov 2015 21:21:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 83174 invoked by uid 89); 4 Nov 2015 21:21:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 04 Nov 2015 21:21:14 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 017592971E; Wed, 4 Nov 2015 16:21:13 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id diXZ1w6kOmG2; Wed, 4 Nov 2015 16:21:12 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C66D029078; Wed, 4 Nov 2015 16:21:12 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 63E07446B0; Wed, 4 Nov 2015 13:21:11 -0800 (PST) Date: Wed, 04 Nov 2015 21:21:00 -0000 From: Joel Brobecker To: Fei Jie Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/3] Add tesecases for examine/display/list Message-ID: <20151104212111.GN4009@adacore.com> References: <1446620987-4140-1-git-send-email-feij.fnst@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1446620987-4140-1-git-send-email-feij.fnst@cn.fujitsu.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-11/txt/msg00159.txt.bz2 > These patches add testcases to test examine/display/list under different conditions: > *examine address in different data types > *display data in different types, enable/disable display > *list with more options Thanks for providing new testcases, we can always use additional testing! First, a few comments, before I delve into reviewing the patches? (1) The GDB project requires that the copyright to all changes integrated by assigned to the FSF. Do you have a copyright assignment on file with the FSF? I tried looking at the current records, and did not find you. If you don't, then let me know, and we'll start the paper work. (2) I noticed that your emails were not following some of the guidelines we have for patch submission. The guidelines should all be explained at this page: https://sourceware.org/gdb/wiki/ContributionChecklist (3) For testcases, there is a "cookbook" that provides best practices. https://sourceware.org/gdb/wiki/GDBTestcaseCookbook -- Joel