From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88777 invoked by alias); 3 Nov 2015 16:13:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88766 invoked by uid 89); 3 Nov 2015 16:13:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e06smtp05.uk.ibm.com Received: from e06smtp05.uk.ibm.com (HELO e06smtp05.uk.ibm.com) (195.75.94.101) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Tue, 03 Nov 2015 16:13:27 +0000 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 3 Nov 2015 16:13:24 -0000 Received: from d06dlp03.portsmouth.uk.ibm.com (9.149.20.15) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 3 Nov 2015 16:13:22 -0000 X-IBM-Helo: d06dlp03.portsmouth.uk.ibm.com X-IBM-MailFrom: uweigand@de.ibm.com X-IBM-RcptTo: gdb-patches@sourceware.org Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id B3EC21B08070 for ; Tue, 3 Nov 2015 16:13:35 +0000 (GMT) Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id tA3GDMQr6750632 for ; Tue, 3 Nov 2015 16:13:22 GMT Received: from d06av01.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id tA3GDL3w021439 for ; Tue, 3 Nov 2015 09:13:21 -0700 Received: from oc7340732750.ibm.com (dyn-9-152-213-152.boeblingen.de.ibm.com [9.152.213.152]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id tA3GDLR3021433; Tue, 3 Nov 2015 09:13:21 -0700 Received: by oc7340732750.ibm.com (Postfix, from userid 500) id 7F0C92665; Tue, 3 Nov 2015 17:13:21 +0100 (CET) Subject: Re: [PATCH v3 2/2] gdb/s390-linux: Step over MVCLE+JO (and similiar) as a unit. To: koriakin@0x04.net (=?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?=) Date: Tue, 03 Nov 2015 16:13:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, koriakin@0x04.net (=?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?=) In-Reply-To: <1446565762-4807-1-git-send-email-koriakin@0x04.net> from "=?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?=" at Nov 03, 2015 04:49:22 PM MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-Id: <20151103161321.7F0C92665@oc7340732750.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15110316-0021-0000-0000-000004B0C455 X-SW-Source: 2015-11/txt/msg00102.txt.bz2 Marcin KoÅcielnicki wrote: > gdb/ChangeLog: > > PR/18376 > * gdb/s390-linux-tdep.c (s390_is_partial_instruction): New function. > (s390_software_single_step): New function. > (s390_displaced_step_hw_singlestep): New function. > (s390_gdbarch_init): Fill gdbarch slots with the above. > + /* Special handling only if recording. */ > + if (!record_full_is_used()) > + return 0; > + > + /* First, match a partial instruction. */ > + if (!s390_is_partial_instruction(gdbarch, loc, &len)) > + return 0; Coding style issue: space before ( for function calls. Patch is OK with that change. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com