From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112518 invoked by alias); 3 Nov 2015 14:17:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112501 invoked by uid 89); 3 Nov 2015 14:17:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e06smtp13.uk.ibm.com Received: from e06smtp13.uk.ibm.com (HELO e06smtp13.uk.ibm.com) (195.75.94.109) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Tue, 03 Nov 2015 14:17:16 +0000 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 3 Nov 2015 14:17:13 -0000 Received: from d06dlp02.portsmouth.uk.ibm.com (9.149.20.14) by e06smtp13.uk.ibm.com (192.168.101.143) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 3 Nov 2015 14:17:10 -0000 X-IBM-Helo: d06dlp02.portsmouth.uk.ibm.com X-IBM-MailFrom: uweigand@de.ibm.com X-IBM-RcptTo: gdb-patches@sourceware.org Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 45C412190056 for ; Tue, 3 Nov 2015 14:17:06 +0000 (GMT) Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id tA3EHAc87799094 for ; Tue, 3 Nov 2015 14:17:10 GMT Received: from d06av04.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id tA3EH8Qd025860 for ; Tue, 3 Nov 2015 07:17:09 -0700 Received: from oc7340732750.ibm.com (dyn-9-152-213-152.boeblingen.de.ibm.com [9.152.213.152]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id tA3EH4GG025709; Tue, 3 Nov 2015 07:17:04 -0700 Received: by oc7340732750.ibm.com (Postfix, from userid 500) id 4192E2665; Tue, 3 Nov 2015 15:17:04 +0100 (CET) Subject: Re: [PATCH v3 1/2] gdb: Add process record and replay support for s390. To: koriakin@0x04.net (=?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?=) Date: Tue, 03 Nov 2015 14:17:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, koriakin@0x04.net (=?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?=) In-Reply-To: <1446558951-930-1-git-send-email-koriakin@0x04.net> from "=?UTF-8?q?Marcin=20Ko=C5=9Bcielnicki?=" at Nov 03, 2015 02:55:51 PM MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-Id: <20151103141704.4192E2665@oc7340732750.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15110314-0013-0000-0000-000007892DB0 X-SW-Source: 2015-11/txt/msg00084.txt.bz2 Marcin KoÅcielnicki wrote: > gdb/ChangeLog: > > PR/18376 > * gdb/configure.tgt: Add linux-record.o to s390*-linux. > * gdb/s390-linux-tdep.c: #include "linux-record.h", "record-full.h" > (s390_linux_record_tdep): New static global variable. > (s390x_linux_record_tdep): New static global variable. > (s390_all_but_pc_registers_record): New function. > (s390_canonicalize_syscall): New function. > (s390_linux_syscall_record): New function. > (s390_linux_record_signal): New function. > (s390_record_calc_disp_common): New function. > (s390_record_calc_disp): New function. > (s390_record_calc_disp_vsce): New function. > (s390_record_calc_rl): New function. > (s390_record_gpr_g): New function. > (s390_record_gpr_h): New function. > (s390_record_vr): New function. > (s390_process_record): New function. > (s390_init_linux_record_tdep): New function. > (s390_gdbarch_init): Fill record function slots. > > gdb/testsuite/ChangeLog: > > * gdb.reverse/s390-mvcle.c: New test. > * gdb.reverse/s390-mvcle.exp: New file. > * lib/gdb.exp: Enable reverse tests on s390*-linux. > --- > First patch fixed according to comments from review. LCBB also moved to > 32-bit destination section. I'm still working on the second patch, and will > resubmit it later. > > I haven't changed size_msqid_ds and size_shmid_ds - the target-independent > code for recording ipc operations is horribly broken, and doesn't distinguish > between calls that should use msqid_ds and msqid64_ds (or msginfo, for that > matter), using size_msqid_ds either way (same for shm). Since modern glibc > uses msqid64_ds, this is the less wrong size to use. I'll cook up a proper > fix for the IPC problem soon on all supported targets, for now let's leave > it as msqid64_ds size. Ah, I see. Well, saving a slightly too large size in some cases doesn't really matter all that much, so I'm fine with this. The patch is OK. Thanks again for working on this! Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com