From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24668 invoked by alias); 27 Oct 2015 09:31:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24652 invoked by uid 89); 27 Oct 2015 09:31:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 X-HELO: mail-wi0-f175.google.com Received: from mail-wi0-f175.google.com (HELO mail-wi0-f175.google.com) (209.85.212.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 27 Oct 2015 09:31:09 +0000 Received: by wicll6 with SMTP id ll6so150419922wic.0 for ; Tue, 27 Oct 2015 02:31:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=KO2EMeb+mjJ1aXMu3qQ0sZCmad1yAUsMEjvCMoqvNy8=; b=nGS5IzvrgZxObUewsw1LVrOohwfsOuD+5peCjM8CWlTf3JnxpOhryEp2mKue87IRar kAfLvJFOu1Men+iSVU2eYLKZJGGHG/hLsLbAp3KXr1GYTjXNCv42VvRiU6gblTEfaW4X ZcMoPkntNThC9hWPQp5KskbSBmyG+tuaDoDoKL+PbJLjZdT9XQQag0Wz28F/Hbw14SoO yTIlsE14K28Sga5SlKHnU9OnGEXFI68OJlwonhiYDhSsFDHYfe6euU5f1orMj72SmfDp sW/IWZkOwU8gl24hc184NvS1AuQNfNXhwh+WCVB8SdMlg3VKauh0vw2DHTihQZxx9WkB yaSw== X-Gm-Message-State: ALoCoQkyAuXSssjyWBqos5swH219jFPXUjDC6zceL850FFBk9Cb+rurHOuUrGhtbPXMCw6FxsmRZ X-Received: by 10.194.60.226 with SMTP id k2mr26502346wjr.21.1445938266440; Tue, 27 Oct 2015 02:31:06 -0700 (PDT) Received: from localhost (host81-158-6-13.range81-158.btcentralplus.com. [81.158.6.13]) by smtp.gmail.com with ESMTPSA id cq8sm15857481wib.12.2015.10.27.02.31.05 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Oct 2015 02:31:05 -0700 (PDT) Date: Tue, 27 Oct 2015 11:36:00 -0000 From: Andrew Burgess To: Fei Jie Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Add testcases to gdb.base/break.exp Message-ID: <20151027093104.GH23628@embecosm.com> References: <1445924337-6514-1-git-send-email-feij.fnst@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1445924337-6514-1-git-send-email-feij.fnst@cn.fujitsu.com> X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00600.txt.bz2 * Fei Jie [2015-10-27 13:38:57 +0800]: > *test break at offset -1 > *test break with address > *test break with non-existed address > *test break with non-existed condition > --- > gdb/testsuite/gdb.base/break.exp | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/gdb/testsuite/gdb.base/break.exp b/gdb/testsuite/gdb.base/break.exp > index f879bc8..3a997d1 100644 > --- a/gdb/testsuite/gdb.base/break.exp > +++ b/gdb/testsuite/gdb.base/break.exp > @@ -399,6 +399,10 @@ set bp_location10 [gdb_get_line_number "set breakpoint 10 here"] > gdb_test "break +1" \ > "Breakpoint.*at.* file .*$srcfile, line $bp_location10\\." \ > "breakpoint offset +1" > +#Test break at offset -1 > +gdb_test "break -1" \ > + "Note: breakpoint 6 also set at.*Breakpoint.*at.* file .*$srcfile, line.*" \ > + "breakpoint offset -1" > > # Check to see if breakpoint is hit when stepped onto > > @@ -940,3 +944,17 @@ gdb_test_no_output "set \$foo=81.5" \ > gdb_test "break $srcfile:\$foo" \ > "Convenience variables used in line specs must have integer values.*" \ > "set breakpoint via non-integer convenience variable disallowed" > + > +#Test break with address > +gdb_test "break *0x400795" \ > + "Breakpoint.*at.* .*$srcfile, line.*" \ > + "breakpoint with address" That address is not going to be valid for every target. You'll need to place a label in the code somewhere, take the address of the label, and use that to generate a breakpoint. Thanks, Andrew