From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7787 invoked by alias); 21 Oct 2015 19:41:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7772 invoked by uid 89); 21 Oct 2015 19:41:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 21 Oct 2015 19:41:43 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D6FDA118252; Wed, 21 Oct 2015 15:41:41 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id CMPMAEiStIkJ; Wed, 21 Oct 2015 15:41:41 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id A818111824F; Wed, 21 Oct 2015 15:41:41 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 2539C41C7F; Wed, 21 Oct 2015 15:41:41 -0400 (EDT) Date: Thu, 22 Oct 2015 09:59:00 -0000 From: Joel Brobecker To: Keven Boell Cc: gdb-patches@sourceware.org, keven.boell@intel.com Subject: Re: [PATCH 1/2] fort_dyn_array: add basic fortran dyn array support Message-ID: <20151021194141.GB3971@adacore.com> References: <1435754532-17922-1-git-send-email-keven.boell@intel.com> <1435754532-17922-2-git-send-email-keven.boell@intel.com> <20150721180502.GN7406@adacore.com> <55C213C7.7070202@linux.intel.com> <20150805202301.GB14992@adacore.com> <51130.172.28.205.135.1438861308.squirrel@linux.intel.com> <20150820125159.GD4571@adacore.com> <5613D0DC.3040908@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5613D0DC.3040908@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-10/txt/msg00430.txt.bz2 > Thanks for the review and sorry for the long delay. Here is the updated patch. Not to worry. At this point of the process, the number of changes that were left to be made before making the patch acceptable were very small, so it was easy for me to get back into it. > 2015-03-13 Keven Boell > > * dwarf2read.c (set_die_type): Add read of > DW_AT_allocated and DW_AT_associated. > * f-typeprint.c: New include of typeprint.h > (f_print_type): Add check for allocated/associated > status of type. > (f_type_print_varspec_suffix): Add check for > allocated/associated status of type. > * gdbtypes.c (create_array_type_with_stride): > Add check for valid data location of type in > case allocated or associated attributes are set. > Length of an array should be only calculated if > allocated or associated is resolved as true. > (is_dynamic_type_internal): Add check for allocated/ > associated. > (resolve_dynamic_array): Evaluate allocated/associated > properties. > * gdbtypes.h (enum dynamic_prop_node_kind): > : New enums. > (TYPE_ALLOCATED_PROP, TYPE_ASSOCIATED_PROP): New macros. > (type_not_allocated): New function. > (type_not_associated): New function. > * valarith.c (value_subscripted_rvalue): Add check for > allocated/associated. > * valprint.c: New include of typeprint.h. > (valprint_check_validity): Add check for allocated/associated. > (value_check_printable): Add check for allocated/ > associated. > * typeprint.h (val_print_not_allocated): New function. > (val_print_not_associated): New function. > * typeprint.c (val_print_not_allocated): New function. > (val_print_not_associated): New function. > > testsuite/gdb.fortran: > > * vla-alloc-assoc.exp: New file. > * vla-datatypes.exp: New file. > * vla-datatypes.f90: New file. > * vla-history.exp: New file. > * vla-ptype-sub.exp: New file. > * vla-ptype.exp: New file. > * vla-sizeof.exp: New file. > * vla-sub.f90: New file. > * vla-value-sub-arbitrary.exp: New file. > * vla-value-sub-finish.exp: New file. > * vla-value-sub.exp: New file. > * vla-value.exp: New file. > * vla-ptr-info.exp: New file. > * vla.f90: New file. > > testsuite/gdb.mi: > > * mi-vla-fortran.exp: New file. > * vla.f90: New file. The patch is approved, and I have now pushed it. Congratulations! (and thank you for your perseverance :-)). Small note, on something I noticed only at the very end. For the ChangeLog entries, and in particular for the testsuite files, therer is only one ChangeLog file, in gdb/testsuite/ChangeLog. So, all the entries in the testsuite directory should be together, and relative to the testsuite, which means the filenames needed to be prefixed with either gdb.fortran/ or gdb.mi. In other words, I changed it to the following entry in gdb/testsuite/ChangeLog: * gdb.fortran/vla-alloc-assoc.exp: New file. * gdb.fortran/vla-datatypes.exp: New file. * gdb.fortran/vla-datatypes.f90: New file. * gdb.fortran/vla-history.exp: New file. * gdb.fortran/vla-ptype-sub.exp: New file. * gdb.fortran/vla-ptype.exp: New file. * gdb.fortran/vla-sizeof.exp: New file. * gdb.fortran/vla-sub.f90: New file. * gdb.fortran/vla-value-sub-arbitrary.exp: New file. * gdb.fortran/vla-value-sub-finish.exp: New file. * gdb.fortran/vla-value-sub.exp: New file. * gdb.fortran/vla-value.exp: New file. * gdb.fortran/vla-ptr-info.exp: New file. * gdb.mi/mi-vla-fortran.exp: New file. * gdb.mi/vla.f90: New file. -- Joel