From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63805 invoked by alias); 20 Oct 2015 17:14:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 63767 invoked by uid 89); 20 Oct 2015 17:14:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,FSL_HELO_BARE_IP_2,RCVD_IN_DNSWL_LOW,RCVD_NUMERIC_HELO,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 X-HELO: plane.gmane.org Received: from plane.gmane.org (HELO plane.gmane.org) (80.91.229.3) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 20 Oct 2015 17:14:51 +0000 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1ZoaUi-0003De-U7 for gdb-patches@sourceware.org; Tue, 20 Oct 2015 19:14:41 +0200 Received: from 209.226.137.108 ([209.226.137.108]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 20 Oct 2015 19:14:40 +0200 Received: from aristovski by 209.226.137.108 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 20 Oct 2015 19:14:40 +0200 To: gdb-patches@sourceware.org From: Aleksandar Ristovski Subject: Re: [PATCH 3/3] (patch 2/4, v2) [nto] Implement procfs_pid_to_exec_file. Date: Tue, 20 Oct 2015 18:19:00 -0000 Message-ID: <56267677.5000206@qnx.com> References: <56263FED.3050602@redhat.com> <1445351294-18179-1-git-send-email-aristovski@qnx.com> <1445351294-18179-4-git-send-email-aristovski@qnx.com> <56265C92.3010107@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 In-Reply-To: <56265C92.3010107@redhat.com> X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00379.txt.bz2 Message-ID: <20151020181900.pbQxBSl5Zg88P_YpAGPO2hGWda6PL7-jpdo6WGcdPfM@z> On 15-10-20 11:24 AM, Pedro Alves wrote: > On 10/20/2015 03:28 PM, Aleksandar Ristovski wrote: >> gdb/ChangeLog: >> >> * gdb/nto-procfs.c (procfs_pid_to_exec_file): New function. >> (init_procfs_targets): Wire new function. >> --- >> gdb/nto-procfs.c | 28 ++++++++++++++++++++++++++++ >> 1 file changed, 28 insertions(+) >> >> diff --git a/gdb/nto-procfs.c b/gdb/nto-procfs.c >> index ac54c32..e7882ba 100644 >> --- a/gdb/nto-procfs.c >> +++ b/gdb/nto-procfs.c >> @@ -617,6 +617,33 @@ procfs_files_info (struct target_ops *ignore) >> (nodestr != NULL) ? nodestr : "local node"); >> } >> >> +/* Read executable file name for the given PID. */ >> + > > Please write instead: > > /* Target to_pid_to_exec_file implementation. */ > >> +static char * >> +procfs_pid_to_exec_file (struct target_ops *ops, const int pid) >> +{ > > OK with that change. > > Thanks, > Pedro Alves > > Pushed with: +/* Target to_pid_to_exec_file implementation. */ + +static char * +procfs_pid_to_exec_file (struct target_ops *ops, const int pid) Thank you, Aleksandar Ristovski