From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47133 invoked by alias); 20 Oct 2015 17:09:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 47122 invoked by uid 89); 20 Oct 2015 17:09:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,FSL_HELO_BARE_IP_2,RCVD_IN_DNSWL_LOW,RCVD_NUMERIC_HELO,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 X-HELO: plane.gmane.org Received: from plane.gmane.org (HELO plane.gmane.org) (80.91.229.3) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 20 Oct 2015 17:09:06 +0000 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1ZoaPF-0006iT-6Z for gdb-patches@sourceware.org; Tue, 20 Oct 2015 19:09:01 +0200 Received: from 209.226.137.108 ([209.226.137.108]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 20 Oct 2015 19:09:01 +0200 Received: from aristovski by 209.226.137.108 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 20 Oct 2015 19:09:01 +0200 To: gdb-patches@sourceware.org From: Aleksandar Ristovski Subject: Re: [PATCH 1/3] (patch 2/4, v2) [nto] Fixes for nto procfs. Date: Tue, 20 Oct 2015 17:14:00 -0000 Message-ID: <56267525.9030401@qnx.com> References: <56263FED.3050602@redhat.com> <1445351294-18179-1-git-send-email-aristovski@qnx.com> <1445351294-18179-2-git-send-email-aristovski@qnx.com> <5626579D.4090900@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 In-Reply-To: <5626579D.4090900@redhat.com> X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00375.txt.bz2 Message-ID: <20151020171400.wS6YbDCpy3iMYhUbKgWdwUA-q-35jkK4eTbN8xt7IeA@z> On 15-10-20 11:02 AM, Pedro Alves wrote: > On 10/20/2015 03:28 PM, Aleksandar Ristovski wrote: >> Fix errnoeus construction of procfs path. The issue is, after the first >> info pidlist or first run, the path for local node (the most common node) >> will be reset to empty which makes subsequent queries and runs impossible. > > Thanks. > >> >> gdb/ChangeLog: >> >> * nto-procfs.c (nto_procfs_path): Rename to... >> (nodestr): ... this, and change type. >> (nto_node): Use new variable and logic accordingly. >> (procfs_open_1): Use new variable name. Use local buffer to construct >> procfrs path. >> (procfs_pidlist): Use NODESTR to construct procfs path. >> (procfs_files_info): Use NODESTR to output meaningful text. >> (do_attach): Construct procfs using NODESTR. >> (procfs_create_inferior): Compare pointer to NULL. > > This is OK. > > There are some bits here that seem a bit unrelated, but we're > hitting the point of diminishing returns. > > Thanks, > Pedro Alves Pushed, thank you, Aleksandar Ristovski