From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67186 invoked by alias); 22 Sep 2015 15:00:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 67152 invoked by uid 89); 22 Sep 2015 15:00:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.2 required=5.0 tests=AWL,BAYES_50,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 22 Sep 2015 15:00:27 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id BE8C9294C4; Tue, 22 Sep 2015 11:00:25 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ws+Jb7qdKt0x; Tue, 22 Sep 2015 11:00:25 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id A6018294BC; Tue, 22 Sep 2015 11:00:25 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 450BE40B5C; Tue, 22 Sep 2015 11:00:25 -0400 (EDT) Date: Tue, 22 Sep 2015 15:00:00 -0000 From: Joel Brobecker To: Pierre-Marie de Rodat Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [Ada] Fix handling of array renamings Message-ID: <20150922150025.GA10139@adacore.com> References: <1441178473-18654-1-git-send-email-derodat@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441178473-18654-1-git-send-email-derodat@adacore.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-09/txt/msg00525.txt.bz2 > gdb/ChangeLog: > > * ada-lang.c (ada_evaluate_subexp) : When the input > value is a reference, actually dereference it in order to get > the underlying value. > > gdb/testsuite/ChangeLog: > > * gdb.ada/array_ptr_renaming.exp: New testcase. > * gdb.ada/array_ptr_renaming/foo.adb: New file. > * gdb.ada/array_ptr_renaming/pack.ads: New file. OK with one tiny little suggestion. > +gdb_test "print ntp" " = \\(access pack\\.table_type\\) 0x.*" ^^^ Suggest using $hex.* instead of 0x.* Thanks! And sorry for the late review... -- Joel