From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117365 invoked by alias); 22 Sep 2015 07:50:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 117353 invoked by uid 89); 22 Sep 2015 07:50:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-wi0-f181.google.com Received: from mail-wi0-f181.google.com (HELO mail-wi0-f181.google.com) (209.85.212.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 22 Sep 2015 07:50:38 +0000 Received: by wicfx3 with SMTP id fx3so10826296wic.0 for ; Tue, 22 Sep 2015 00:50:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=wVsGPz5rVj6YZ90l+QtCt+Pt5j39hWP2mp/ZtIxfNBg=; b=gUwGUDN52MLAOTjvS4mYdO3ksY9a1CgeYU2OSm//h5AItLXMU2mwB1cmP8BleixbdP osYa/IBa6WOliGRp+0vLVKhlxGhrMsk5QxTEpMYofYatKu6R5zGCEuO2XUibbh5IqP3A javMwADjsvZWfmHTdSpIQOZR+r96Njyw08SdiNj3PdLvudWxai8ba3LzhY/ZRx8z5mBl UQ7ns37uuv8dr+NbIUIUdsTi95NpQhZ7ik9CE2pT1Ecgwk6iz6gY0xb9bzQ92hsK6T05 GK87enSXFEkXVT18eyVg9BxUtN/0PZHjXBzKDCzIR57mp4YCgqnKs6xxZFTw/+nn2YQx sBjw== X-Gm-Message-State: ALoCoQn0yN6C8oZCnNajeafKPesq2aEatmlnJWts/bOBzNGwEyV//+sbC3outGCBCsi+XGePjocj X-Received: by 10.194.111.198 with SMTP id ik6mr30404044wjb.96.1442908235515; Tue, 22 Sep 2015 00:50:35 -0700 (PDT) Received: from localhost (host81-131-206-173.range81-131.btcentralplus.com. [81.131.206.173]) by smtp.gmail.com with ESMTPSA id bh5sm355524wjb.42.2015.09.22.00.50.34 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Sep 2015 00:50:35 -0700 (PDT) Date: Tue, 22 Sep 2015 07:50:00 -0000 From: Andrew Burgess To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] tui: Simplify tui_alloc_content Message-ID: <20150922075033.GB5430@embecosm.com> References: <1442877416-16659-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442877416-16659-1-git-send-email-simon.marchi@ericsson.com> X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00522.txt.bz2 * Simon Marchi [2015-09-21 19:16:56 -0400]: > > gdb/ChangeLog: > > * tui/tui-data.c (tui_alloc_content): Don't check xmalloc > result. Change type of element_block_ptr. Change allocation to > use XNEWVEC. > --- > gdb/tui/tui-data.c | 41 ++++++++++++++--------------------------- > 1 file changed, 14 insertions(+), 27 deletions(-) > > diff --git a/gdb/tui/tui-data.c b/gdb/tui/tui-data.c > index 2fcd547..ca7502d 100644 > --- a/gdb/tui/tui-data.c > +++ b/gdb/tui/tui-data.c > @@ -573,40 +573,27 @@ tui_win_content > tui_alloc_content (int num_elements, enum tui_win_type type) > { > tui_win_content content; > - char *element_block_ptr; > + struct tui_win_element *element_block_ptr; > int i; > > content = XNEWVEC (struct tui_win_element *, num_elements); > - if (content != NULL) > + > + /* > + * All windows, except the data window, can allocate the > + * elements in a chunk. The data window cannot because items > + * can be added/removed from the data display by the user at any > + * time. > + */ > + if (type != DATA_WIN) > { > - /* > - * All windows, except the data window, can allocate the > - * elements in a chunk. The data window cannot because items > - * can be added/removed from the data display by the user at any > - * time. > - */ > - if (type != DATA_WIN) > + element_block_ptr = XNEWVEC (struct tui_win_element, num_elements); > + for (i = 0; i < num_elements; i++) > { > - element_block_ptr = > - xmalloc (sizeof (struct tui_win_element) * num_elements); > - if (element_block_ptr != NULL) > - { > - for (i = 0; i < num_elements; i++) > - { > - content[i] = (struct tui_win_element *) element_block_ptr; > - init_content_element (content[i], type); > - element_block_ptr += sizeof (struct tui_win_element); > - } > - } > - else > - { > - xfree (content); > - content = (tui_win_content) NULL; > - } > + content[i] = element_block_ptr; > + init_content_element (content[i], type); > + element_block_ptr++; > } > } > - > - return content; > } Doesn't that leave the function without a return? Thanks, Andrew