From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44785 invoked by alias); 21 Sep 2015 21:48:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44771 invoked by uid 89); 21 Sep 2015 21:48:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.2 required=5.0 tests=AWL,BAYES_40,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-wi0-f177.google.com Received: from mail-wi0-f177.google.com (HELO mail-wi0-f177.google.com) (209.85.212.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 21 Sep 2015 21:48:18 +0000 Received: by wicgb1 with SMTP id gb1so134101885wic.1 for ; Mon, 21 Sep 2015 14:48:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=aWJn7t/6DSVJJWZM1R70Z/Y5FWNu5wE85GDcMeQbL70=; b=UI550N8TtnU/Q5OHZo74VlCMxNEjeK47dFnotOMjNQ9IbvXzhQwNxp3/cw0EKTtcaM y1QpagDRCBX7WzLGMkUx1EC3mt6HdTBlCK0bE8B1gHf4gj3KNK366VlLgTlFik9q5Pqo jzZD1v97jNhsod3DgQLxJMlvytiyp2s2F1JUm4vkDB0axXwFdl881MsE2JwkVcWsx64k mTp+fPFb6VujDxuxaatmrgXqbJ98frqBH3tU8lxWOAt4xu2svU+fccPmhdD5WOQTJEZ+ JUeOknicb7d+T4Ljf6LHLeRRBI2OxbOJWCL9VANR0I1P029OXGjtTv8BErvPpvwg2OzF +g2A== X-Gm-Message-State: ALoCoQlVsJC9Xu63vXNspSaIlM5H5FunqQgm6veDZ72LY8Dpzw/njx34OxWZiElRH2IkZVjyHZGt X-Received: by 10.180.93.196 with SMTP id cw4mr16601109wib.54.1442872095115; Mon, 21 Sep 2015 14:48:15 -0700 (PDT) Received: from localhost (host81-131-206-173.range81-131.btcentralplus.com. [81.131.206.173]) by smtp.gmail.com with ESMTPSA id fn4sm14042049wib.11.2015.09.21.14.48.13 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Sep 2015 14:48:14 -0700 (PDT) Date: Mon, 21 Sep 2015 21:48:00 -0000 From: Andrew Burgess To: Markus Metzger Cc: palves@redhat.com, dje@google.com, gdb-patches@sourceware.org Subject: Re: [PATCH 6/6] btrace: use gdb_disassembly_vec and new source interleaving method Message-ID: <20150921214813.GA5430@embecosm.com> References: <1442847283-10200-1-git-send-email-markus.t.metzger@intel.com> <1442847283-10200-7-git-send-email-markus.t.metzger@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442847283-10200-7-git-send-email-markus.t.metzger@intel.com> X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00515.txt.bz2 * Markus Metzger [2015-09-21 16:54:43 +0200]: > Use the new source interleaving method. We stick to the /m modifier. > The old version is broken and there's no point in keeping it as alternative > to this new version. > > /* The to_insn_history method of target record-btrace. */ > diff --git a/gdb/record.c b/gdb/record.c > index 71ef973..c17b199 100644 > --- a/gdb/record.c > +++ b/gdb/record.c > @@ -458,7 +458,7 @@ get_insn_history_modifiers (char **arg) > switch (*args) > { > case 'm': > - modifiers |= DISASSEMBLY_SOURCE_DEPRECATED; > + modifiers |= DISASSEMBLY_SOURCE; > modifiers |= DISASSEMBLY_FILENAME; > break; > case 'r': I think that we should make /s the official modifier in order to match the disassembler modifier. We should definitely keep /m for backwards compatibility, though I don't have an issue with it's behaviour changing to match /s. My concern is more about trying to keep the flags consistent as much as possible. The change in flags would need a NEWS and manual update. Thanks, Andrew