From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37520 invoked by alias); 17 Sep 2015 08:39:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 37508 invoked by uid 89); 17 Sep 2015 08:39:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 17 Sep 2015 08:39:02 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 0C6FF461E4; Thu, 17 Sep 2015 08:39:01 +0000 (UTC) Received: from host1.jankratochvil.net (ovpn-116-22.ams2.redhat.com [10.36.116.22]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t8H8cvAv022563 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 17 Sep 2015 04:38:59 -0400 Date: Thu, 17 Sep 2015 08:39:00 -0000 From: Jan Kratochvil To: "Metzger, Markus T" Cc: Pedro Alves , "gdb-patches@sourceware.org" Subject: Re: [PATCH 17/17] infrun: scheduler-locking reverse Message-ID: <20150917083856.GA8544@host1.jankratochvil.net> References: <1441794909-32718-1-git-send-email-markus.t.metzger@intel.com> <1441794909-32718-18-git-send-email-markus.t.metzger@intel.com> <55F03A12.80307@redhat.com> <20150912194344.GA7575@host1.jankratochvil.net> <20150915171931.GA2056@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00400.txt.bz2 Hello Markus, On Wed, 16 Sep 2015 09:59:23 +0200, Metzger, Markus T wrote: > > If I/we make schedlock_step the default then this code of your patch gets > > disabled: > > > > + else if ((scheduler_mode == schedlock_reverse) > > + && ((execution_direction == EXEC_REVERSE) > > + || target_record_is_replaying (minus_one_ptid))) > > + { > > + /* User-settable 'scheduler' mode requires solo thread resume during > > + reverse/replay stepping. */ > > + resume_ptid = inferior_ptid; > > + } > > Yes. But the code above this in infrun.c then applies: > > else if ((scheduler_mode == schedlock_on) > || (scheduler_mode == schedlock_step && step)) > { > /* User-settable 'scheduler' mode requires solo thread > resume. */ > resume_ptid = inferior_ptid; > } OK, I get it now. I misunderstood it all despite word by word the new description is right. I would suggest changing the proposed: off == no locking (threads may preempt at any time)\n\ on == full locking (no thread except the current thread may run)\n\ step == scheduler locked during stepping commands (step, next, stepi, nexti).\n\ reverse == scheduler locked during reverse/replay execution.\n\ to: off == no locking (threads may preempt at any time)\n\ on == full locking (no thread except the current thread may run)\n\ This applies to both normal and reverse/replay execution.\n\ step == scheduler locked during stepping commands (step, next, stepi, nexti).\n\ This applies to both normal and reverse/replay execution.\n\ reverse == scheduler fully locked only during reverse/replay execution.\n\ And even gdb.texinfo somehow accordingly. Thanks, Jan