From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113815 invoked by alias); 12 Sep 2015 19:43:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 113800 invoked by uid 89); 12 Sep 2015 19:43:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 12 Sep 2015 19:43:49 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 543E6461ED; Sat, 12 Sep 2015 19:43:48 +0000 (UTC) Received: from host1.jankratochvil.net (ovpn-116-22.ams2.redhat.com [10.36.116.22]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t8CJhidu008761 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 12 Sep 2015 15:43:47 -0400 Date: Sat, 12 Sep 2015 19:43:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: Markus Metzger , gdb-patches@sourceware.org Subject: Re: [PATCH 17/17] infrun: scheduler-locking reverse Message-ID: <20150912194344.GA7575@host1.jankratochvil.net> References: <1441794909-32718-1-git-send-email-markus.t.metzger@intel.com> <1441794909-32718-18-git-send-email-markus.t.metzger@intel.com> <55F03A12.80307@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55F03A12.80307@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00265.txt.bz2 On Wed, 09 Sep 2015 15:54:26 +0200, Pedro Alves wrote: > On 09/09/2015 11:35 AM, Markus Metzger wrote: > > Record targets behave as if scheduler-locking were on during replay/reverse > > execution. Add a new scheduler-locking option "reverse" to make this implicit > > behaviour explicit. It behaves like "on" during reverse/replay execution and > > like "off" during normal execution. > > > > By making the current behaviour a scheduler-locking option, we allow the user > > to change it. Since it is the current behaviour, this new option is also > > the new default. > > Hmm. The code looks fine. But I should point out that if a user > has "schedlock step" in their gdbinit, they'll miss this. Fedora's gdb > actually currently defaults to schedlock=step. Thanks for bringing it up. I would have hard time mergin this patch's: -static const char *scheduler_mode = schedlock_off; +static const char *scheduler_mode = schedlock_reverse; with http://pkgs.fedoraproject.org/cgit/gdb.git/tree/gdb-6.6-scheduler_locking-step-is-default.patch -static const char *scheduler_mode = schedlock_off; +static const char *scheduler_mode = schedlock_step; My guess is there could be a new setting "set reverse-scheduler-locking" also with "off/step/on" as it seems to me "step" also makes sense for the scheduler locking in reverse mode. Or better "set reverse-scheduler-locking" with "off/on" where "on" would behave for reverse mode as "step" if "set scheduler-locking" is set to "step". I do not mind which way but I do not find the current user interface great. Thanks, Jan