From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44093 invoked by alias); 3 Sep 2015 15:46:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44082 invoked by uid 89); 3 Sep 2015 15:46:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=AWL,BAYES_20,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 03 Sep 2015 15:46:21 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 4B32729039; Thu, 3 Sep 2015 11:46:19 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id NdIRNgqIWYa9; Thu, 3 Sep 2015 11:46:19 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 1B9E029024; Thu, 3 Sep 2015 11:46:19 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id A63EB4736F; Thu, 3 Sep 2015 08:46:17 -0700 (PDT) Date: Thu, 03 Sep 2015 15:46:00 -0000 From: Joel Brobecker To: Pierre-Marie de Rodat Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [Ada] Make string_char_type a true TYPE_CODE_CHAR type in Ada Message-ID: <20150903154617.GE3356@adacore.com> References: <1441275358-19855-1-git-send-email-derodat@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441275358-19855-1-git-send-email-derodat@adacore.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-09/txt/msg00062.txt.bz2 > gdb/ChangeLog: > > * ada-lang.c (ada_language_arch_info): Create a TYPE_CODE_CHAR > type instead of a TYPE_CODE_INT one for the string_char_type > and the ada_primitive_type_char types. > > gdb/testsuite/ChangeLog: > > * gdb.ada/funcall_char.exp: New testcase. > * gdb.ada/funcall_char/foo.adb: New file. Looks good to me, Pierre-Marie. Go ahead and push. Thanks, -- Joel