From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118110 invoked by alias); 3 Sep 2015 12:40:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 118083 invoked by uid 89); 3 Sep 2015 12:40:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,KAM_STOCKGEN,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 03 Sep 2015 12:40:50 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 5ABD429363; Thu, 3 Sep 2015 08:40:48 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id jjE5ebZhO402; Thu, 3 Sep 2015 08:40:48 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 1F75B292D7; Thu, 3 Sep 2015 08:40:48 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 9539C472C4; Thu, 3 Sep 2015 05:40:46 -0700 (PDT) Date: Thu, 03 Sep 2015 12:40:00 -0000 From: Joel Brobecker To: Pierre-Marie de Rodat Cc: Doug Evans , Kevin Buettner , gdb-patches@sourceware.org Subject: Re: [PATCH] Add proper handling for non-local references in nested functions Message-ID: <20150903124046.GD3356@adacore.com> References: <55775EB0.4080701@adacore.com> <55AF5F7E.5000600@adacore.com> <20150722173957.7ed51f18@pinnacle.lan> <55B0C583.6050601@adacore.com> <55BB538B.7090104@adacore.com> <55D1E2B5.4000200@adacore.com> <20150902234947.GA575@adacore.com> <55E7F741.70400@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55E7F741.70400@adacore.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-09/txt/msg00054.txt.bz2 > Thank you very much for the investigation and the fix! You are welcome. > > >As also mentioned in the revision log of the patch, we can probably > >do some refactoring, or perhaps a different API in the vector that > >just extracts the needed data (per_cu, at the moment) from symbol's > >SYMBOL_LOCATION_BATON. Then, instead of calling the method to get > >the function frame_base, you have a function that gets it by using > >that different symbol_block_ops function. > > I will give it a try and submit a patch but indeed, let's first do fix the > crash first. Doug will probably be the person reviewing the change. If it gets approved while I am away, would you mind pushing it for me? Thanks! -- Joel