From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64486 invoked by alias); 30 Aug 2015 13:46:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 64475 invoked by uid 89); 30 Aug 2015 13:46:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-wi0-f173.google.com Received: from mail-wi0-f173.google.com (HELO mail-wi0-f173.google.com) (209.85.212.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sun, 30 Aug 2015 13:46:16 +0000 Received: by wicpl12 with SMTP id pl12so6355773wic.1 for ; Sun, 30 Aug 2015 06:46:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=AUfOAXVPk8nfs1AJ0jasFC66VxKVaZxNUsd1AWDL7/s=; b=eCCX4FRHI1ZUyAbUZmCXNhRBqDMQv2dprfxRbMA42KSiR18gMHVb4EwlFCj760cxxK /sixm56XiMKgkftf7L7gOF8XnpqHKBF8gMEBMD14FkZWUrNmNkjpxfXVRGuxjcC6z5tA k02S7jZChorZE+o9bVn1ZLX/OIgZf/jg7UfGqm2MjI3tm1kFAMaY5wIRmosgKHisCdWz Jr7HiWlgKr4ugCl5WsaA/MiIqu6MkQ3tGBVok93JeZzDBfWQdt+221VfynzjtQHYNRJX VrgP1n6VzSRdmDWXVu6zTZYcyo8tuNtvP27HpVLtt8YbAPgRbMx6ayFgw6DLO2Gwvzaw QcZg== X-Gm-Message-State: ALoCoQnvSeCZeDNua86h1nxxBzlqudHCJmv9vwwpcxgiwkYq267f/+G6vbMZYC+Fm/oQYlNoXHBe X-Received: by 10.180.20.210 with SMTP id p18mr11951416wie.6.1440942373154; Sun, 30 Aug 2015 06:46:13 -0700 (PDT) Received: from localhost (host86-146-54-249.range86-146.btcentralplus.com. [86.146.54.249]) by smtp.gmail.com with ESMTPSA id mc18sm13224786wic.23.2015.08.30.06.46.12 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 30 Aug 2015 06:46:12 -0700 (PDT) Date: Sun, 30 Aug 2015 13:46:00 -0000 From: Andrew Burgess To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: Re: [RFC] Casting NULL pointer Message-ID: <20150830134611.GA6579@embecosm.com> References: <20150830100944.GA3916@embecosm.com> <201508301233.t7UCX0Nv012040@glazunov.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201508301233.t7UCX0Nv012040@glazunov.sibelius.xs4all.nl> X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00860.txt.bz2 * Mark Kettenis [2015-08-30 14:33:00 +0200]: > > Date: Sun, 30 Aug 2015 11:09:45 +0100 > > From: Andrew Burgess > > > > There are a small (~26) number of places where the NULL pointer is > > cast list this: > > > > char *wname = (char *) NULL; > > > > This compares to a huge number of places (~726) where we don't use a > > cast, so: > > > > const char *name = NULL; > > > > I've never thought that the cast was either necessary or a > > particularly good idea, it feels like unneeded clutter. > > The cast isn't necessary in assignments like that. However it is > still necessary to cast NULL to an appropriate pointer when passing it > as an argument to a varargs function. Indeed. Specifically, these are the cases I'm looking at: $ grep -re " = ([^)]\+\*\\s\?)\\s\?NULL" binutils-gdb/gdb/* Thanks, Andrew