[pushed] Warn when accessing binaries from remote targets

Gary Benson
2015-08-21T16:23:30Z

Pedro Alves wrote:
> On 08/13/2015 02:23 PM, Gary Benson wrote:
> > + if (warn_if_slow)
> > + {
> > + static int warning_issued = 0;
> > +
> > + printf_unfiltered (_("Reading %s from remote target...\n"),
> > + filename);
> > +
> > + if (!warning_issued)
> > + {
> > + warning (_("File transfers from remote targets can be slow."
> > + " Use \"set sysroot\" with no arguments to access"
> > + " files locally instead."));
>
> I wonder whether "with no arguments" is necessary here. I'd suggest
> dropping that bit. It think it may even be confusing, as what the
> user should do is point at a local copy of the target filesystem,
> using "set sysroot /path/to/copy". The host's filesystem is not
> necessarily the correct one, and often isn't.
>
> Otherwise this looks good to me.

Pushed to master and 7.10 with that change.

Thanks,
Gary

--