From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76545 invoked by alias); 13 Aug 2015 09:10:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76526 invoked by uid 89); 13 Aug 2015 09:10:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 13 Aug 2015 09:10:17 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id AACF132B71B; Thu, 13 Aug 2015 09:10:15 +0000 (UTC) Received: from blade.nx (ovpn-116-40.ams2.redhat.com [10.36.116.40]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t7D9AEcR028927; Thu, 13 Aug 2015 05:10:15 -0400 Received: by blade.nx (Postfix, from userid 1000) id 1B399264516; Thu, 13 Aug 2015 10:10:14 +0100 (BST) Date: Thu, 13 Aug 2015 09:10:00 -0000 From: Gary Benson To: Sandra Loosemore Cc: gdb-patches@sourceware.org, Pedro Alves , Doug Evans , Joel Brobecker Subject: Re: [PATCH] Make remote transfers interruptible Message-ID: <20150813091013.GA25643@blade.nx> References: <55C3A10F.3010106@codesourcery.com> <1439389814-29211-1-git-send-email-gbenson@redhat.com> <55CB8300.3060004@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55CB8300.3060004@codesourcery.com> X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00340.txt.bz2 Sandra Loosemore wrote: > On 08/12/2015 08:30 AM, Gary Benson wrote: > >Sandra Loosemore wrote: > > >On 08/05/2015 09:28 AM, Gary Benson wrote: > > > > This commit makes it possible to interrupt slow remote file > > > > transfers. > > > > > > > > gdb/ChangeLog: > > > > > > > > * gdb_bfd.c (gdb_bfd_iovec_fileio_pread): Add QUIT call. > > > > > > It still does not work for me. :-( > > > > Could you please try this newer version and see if it allows you > > to interrupt the remote transfers? > > This version still doesn't make the transfer interruptable with ^C. Then I am out of ideas :( I can interrupt on my setup with either patch (I tested it by adding a 100ms usleep in gdbserver/hostio.c handle_pread). I will push a warning-printing patch to HEAD, so that users in your situation at least have some feedback on what is happening. Could you please look at making the transfers interruptible? Joel, would you like me to also push it to the 7.10 branch, or will you do that? > *But*, with this patch, the startup time is reduced from 4 minutes > to 19 seconds. Huh? Is it really transferring the entire file > contents, or was the time being used for some GDB-side operation > that is quadratic or exponential in the size of the read requested > rather than the actual byte transfer? Independently of the ^C > issue, I think we need to better understand what is going on here > and better tune the code on both sides of the RSP for large file > transfers. That's pretty weird. It sounds like there's real scope for you to improve performance here. Thanks, Gary -- http://gbenson.net/