> My idea of a testcase comment is at the beginning of the testcase file, > explaining what the test does and why it does it. I'd mention the amd64 > example as well, since it is part of why the test was created in the first > place. > > That should give others enough background to pursue an investigation about > why this potentially fails for them. > > My 2 cents anyway. There is this perception that the testcase was created because of the issue on amd64, but that's not true. The testcase was created, albeit in AdaCore's infrastructure only, to test that "next" in that context works as expected. Only later on did it allow us to find another bug which actually has nothing to do with the initial reason for creating the testcase. I hope I'm not looking like I'm splitting hair, but I feel like there is a bit of a misunderstanding somewhere, probably because the testcase appears as new to the GDB community and was combined with an amd64-specific fix. That being said, I propose the attached patch. I confess I'm not super convinced about the comment on amd64, as I think it might become one day irrelevant. But I don't mind it that much; if it is helpful to others... What do you think? gdb/testsuite/ChangeLog: * gdb.base/dso2dso.exp: Improve the testcase's documentation. -- Joel