From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9397 invoked by alias); 12 Aug 2015 20:33:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9386 invoked by uid 89); 12 Aug 2015 20:33:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 12 Aug 2015 20:33:25 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id B067929064; Wed, 12 Aug 2015 16:33:23 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id BgSdBhcVuTR9; Wed, 12 Aug 2015 16:33:23 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 803E728DF5; Wed, 12 Aug 2015 16:33:23 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 1DD4E46993; Wed, 12 Aug 2015 13:33:22 -0700 (PDT) Date: Wed, 12 Aug 2015 20:33:00 -0000 From: Joel Brobecker To: Luis Machado Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH v4 00/18] All-stop on top of non-stop Message-ID: <20150812203322.GB9183@adacore.com> References: <1432250354-2721-1-git-send-email-palves@redhat.com> <55C4E3BD.8040801@redhat.com> <20150812183208.GA24901@adacore.com> <55CBA0D1.5000203@codesourcery.com> <20150812195948.GH22245@adacore.com> <55CBAA17.4040605@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55CBAA17.4040605@codesourcery.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-08/txt/msg00326.txt.bz2 I tried to clarify the purpose of the testcase by adding a comment inside it. Let me know if this isn't enough, and we'll try to improve. > Ok. So i think i misunderstood the purpose of the testcase there. In reality > the testcase is not testing the fix itself, but rather introducing a new > test not related to the problem, except in the amd64 architecture, where it > really tests the problem. > > It just confused me that the test is generic for other non-amd64 > architectures and specific to the amd64 problem you saw. > > I'd expect a generic solib test to be included in one of our shared library > tests, but then you'd have to shape it in a way that would exercise your > displaced stepping problem. I understand the first paragraph, but I'm having trouble with the last one. The testcase as I wrote it does exercise the issue being fixed on amd64, and I verified that I get 1 FAIL without the patch. Did I misunderstand you? > I see your targets are mostly x86. I can give it a try on a few more > (powerpc, mips, arm, nios) and let you know what i see. How does that sound? Sounds good to me. Bare in mind that the list of targets AdaCore tests on already includes powerpc and sparc, and I forgot ARM that we also test (as a cross, debugging via GDBserver). So I think it's fairly wide already. Our testsuite uses a different technology than dejagnu, though, so we might indeed get some surprises, but I think they will have more to do with scripting than GDB: Except for the platforms that we don't test at AdaCore, I'd expect that any error will mostly be about building the program rather than debugging it. -- Joel