Hi Pedro, On Fri, Aug 07, 2015 at 05:58:37PM +0100, Pedro Alves wrote: > On 05/22/2015 12:18 AM, Pedro Alves wrote: > > v3: https://sourceware.org/ml/gdb-patches/2015-04/msg00662.html > > v2: https://sourceware.org/ml/gdb-patches/2015-04/msg00198.html > > v1: https://sourceware.org/ml/gdb-patches/2015-04/msg00073.html > > > > Compared to v3, a set of minor changes accumulated, to address review > > comments and discussions (i.e., no major functional/design changes), > > plus fixes to a patch that touched all targets (that I noticed > > converted a couple wrong). > > > > I believe I addressed all review comments thus far. Barring comments, > > I'd like to push this in, and expose it to the build bots. > > FYI, I pushed this in. I'm keeping an eye on the build bots. > > If you spot any related problem, please confirm whether > "maint set target-non-stop off" fixes it. This uncovered what I think is a latent bug in the "how-did-we-never- see-this-before" category. Does this patch look OK to you? gdb/ChangeLog: * amd64-tdep.c (amd64_displaced_step_fixup): Fix the mask used to compute RETADDR. gdb/testsuite/ChangeLog: * gdb.base/dso2dso-impl.c, gdb.base/dso2dso-impl.h, gdb.base/dso2dso-pck.c, gdb.base/dso2dso-pck.h, gdb.base/dso2dso.c, gdb.base/dso2dso.exp: New files. Tested on x86_64-linux, no regression. Thanks! -- Joel